Page MenuHomePhabricator
Differential D10014

Preserve line breaks in standard remarkup fields
ClosedPublic
Actions

Authored by sergey.vfx on Jul 22 2014, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 1:10 PM
Unknown Object (File)
Thu, Dec 12, 6:36 AM
Unknown Object (File)
Tue, Dec 10, 10:18 PM
Unknown Object (File)
Thu, Nov 21, 5:42 PM
Unknown Object (File)
Wed, Nov 20, 9:35 AM
Unknown Object (File)
Nov 19 2024, 12:37 PM
Unknown Object (File)
Nov 13 2024, 9:33 PM
Unknown Object (File)
Nov 13 2024, 1:27 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP1888f6141147: Preserve line breaks in standard remarkup fields
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Initially the change is aimed to solve issue with line breaks being lost in projects descriptions. But it is done in a general place so line breaks behavior is more consistent all over the place.

Test Plan
  • Write a multiline description of the project, using single \n for line breakers.
  • View project details in project/view/X?

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sergey.vfx updated this revision to Diff 24071.Jul 22 2014, 3:02 PM
sergey.vfx retitled this revision from to Preserve line breaks in projects descriptions.
sergey.vfx updated this object.
sergey.vfx edited the test plan for this revision. (Show Details)
sergey.vfx added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 22 2014, 3:02 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1835: Diff 24071.Jul 22 2014, 3:04 PM
epriestley requested changes to this revision.Jul 24 2014, 9:04 PM
epriestley edited edge metadata.

I'll accept this if you make the change in PhabricatorStandardCustomFieldRemarkup instead. I think we just have an odd default here. I can look at the default/general case in more detail eventually, but for now let's just swap the default to preserve.

This revision now requires changes to proceed.Jul 24 2014, 9:04 PM
sergey.vfx updated this revision to Diff 24179.Jul 25 2014, 8:00 PM
sergey.vfx edited edge metadata.

Move changes to a standard remarkup custom field

sergey.vfx retitled this revision from Preserve line breaks in projects descriptions to Preserve line breaks in standard remarkup fields.Jul 25 2014, 8:01 PM
sergey.vfx updated this object.
sergey.vfx edited edge metadata.
Harbormaster completed remote builds in B1901: Diff 24179.Jul 25 2014, 8:01 PM
epriestley accepted this revision.Jul 25 2014, 8:11 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jul 25 2014, 8:11 PM
epriestley closed this revision.Jul 25 2014, 8:12 PM
epriestley updated this revision to Diff 24180.

Closed by commit rP1888f6141147 (authored by @sergey.vfx, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
standard/
4 lines

Diff 24180

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php

Loading...
Phabricator · Built by Phacility