HomePhabricator

Move project slug normalization inside project Query

Description

Move project slug normalization inside project Query

Summary:
Ref T10010. We currently require withSlugs() to have properly formatted slugs, but this leads to similar code in several places.

Instead: accept any slug, normalize slugs in the query, return a map so callers can figure out what happened if they want.

This tends to do the right thing by default, while keeping enough information around to do more complex things if necessary. A similar approach for querying commits has worked well in Diffusion.

Test Plan: Added and executed unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10010

Differential Revision: https://secure.phabricator.com/D14888

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Dec 27 2015, 5:20 PM
Reviewer
chad
Differential Revision
D14888: Move project slug normalization inside project Query
Parents
rPaa2089ba6804: Support field previews in EditEngine
Branches
Unknown
Tags
Unknown
Tasks
T10010: Implement Subprojects
Build Status
Buildable 9819
Build 11818: Run Core Tests