Page MenuHomePhabricator
Differential D21837

Provide a simple "Attach File" explicit workflow for files referenced but not attached
ClosedPublic
Actions

Authored by epriestley on May 24 2022, 1:12 AM.
Tags
None
Referenced Files
F13326702: D21837.diff
Sat, Jun 15, 8:30 AM
F13320333: D21837.diff
Fri, Jun 14, 4:23 AM
F13310138: D21837.diff
Mon, Jun 10, 11:01 AM
F13277773: D21837.id52049.diff
Fri, May 31, 12:57 PM
F13275753: D21837.diff
Fri, May 31, 5:09 AM
F13273239: D21837.id.diff
Fri, May 31, 1:43 AM
F13270829: D21837.id52049.diff
Wed, May 29, 12:24 PM
F13270422: D21837.id52049.diff
Wed, May 29, 9:40 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP5493f028dca6: Provide a simple "Attach File" explicit workflow for files referenced but not…
Summary

Ref T13682. Allow users to manually attach files which are referenced (but not attached) via the UI.

Test Plan

Reference files via {F...}, then attached them via the UI workflow.

Diff Detail

Repository
rP Phabricator
Branch
filex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25744
Build 35572: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
base/
controller/
4 lines
files/
application/
10 lines
controller/
136 lines
2 lines
engineextension/
50 lines
phid/
3 lines
query/
25 lines
storage/
9 lines
policy/
storage/
15 lines
transactions/
editor/
1 line
storage/
195 lines
infrastructure/
internationalization/
translation/
14 lines
view/
phui/
12 lines
webroot/
rsrc/
css/
phui/
3 lines

Diff 52048

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileUICurtainAttachController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileUICurtainListController.php

Loading...
View Options

src/applications/files/engineextension/PhabricatorFilesCurtainExtension.php

Loading...
View Options

src/applications/files/phid/PhabricatorFileFilePHIDType.php

Loading...
View Options

src/applications/files/query/PhabricatorFileAttachmentQuery.php

Loading...
View Options

src/applications/files/storage/PhabricatorFileAttachment.php

Loading...
View Options

src/applications/policy/storage/PhabricatorPolicy.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
View Options

src/view/phui/PHUICurtainObjectRefView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-curtain-object-ref-view.css

Loading...
Phabricator · Built by Phacility