Page MenuHomePhabricator

Make project token sorting and normalization a little less hacky
ClosedPublic

Authored by epriestley on Nov 17 2016, 1:05 PM.
Tags
None
Referenced Files
F13212161: D16886.diff
Fri, May 17, 6:26 AM
F13209171: D16886.id.diff
Thu, May 16, 10:20 PM
F13197126: D16886.diff
Sun, May 12, 11:50 PM
F13182709: D16886.id40652.diff
Fri, May 10, 1:38 AM
Unknown Object (File)
Fri, May 3, 9:33 PM
Unknown Object (File)
Fri, May 3, 8:32 AM
Unknown Object (File)
Thu, May 2, 4:16 AM
Unknown Object (File)
Mon, Apr 29, 5:25 PM
Subscribers
None

Details

Summary

Ref T8510. Use "\n" as a delimiter between name sections. Specifically, project "AAA" with tag "zzz" should be a better match for query "AAA" than project "AAA BBB" is.

Make use of this delimiter slighlty more obvious in the UI.

Test Plan
  • Created projects "Phacility" and "Phacility Core Access".
  • Typed "Phacility".
  • Before patch: first hit is "Phacility Core Access".
  • After patch: first hit is "Phacility".
  • Viewed debugging output table, saw visual explanation of behavior.

Diff Detail

Repository
rP Phabricator
Branch
ahead1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14541
Build 18967: Run Core Tests
Build 18966: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make project token sorting and normalization a little less hacky.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 3:10 PM
This revision was automatically updated to reflect the committed changes.