Page MenuHomePhabricator

Fix "Blocked" task queries with multiple subtasks, and update language
ClosedPublic

Authored by epriestley on Jul 28 2016, 5:21 PM.
Tags
None
Referenced Files
F13234453: D16340.diff
Tue, May 21, 3:25 AM
F13229316: D16340.id39294.diff
Mon, May 20, 3:42 PM
F13218159: D16340.id.diff
Sat, May 18, 10:30 AM
F13212404: D16340.diff
Fri, May 17, 6:40 AM
F13198113: D16340.id39294.diff
Mon, May 13, 4:14 AM
F13195970: D16340.diff
Sun, May 12, 10:48 PM
F13179806: D16340.diff
Wed, May 8, 9:27 PM
Unknown Object (File)
Mon, May 6, 9:27 PM
Subscribers
None

Details

Summary

Ref T8126. See that task for discussion. This change:

  • Updates language to be more consistent ("Parents", "Subtasks") since I moved us away from the often-confusing "Block" language in T4788.
  • Fixes bugs with finding the wrong set of tasks if tasks have a mixture of open and closed subtasks or parents.
Test Plan
  • Created four tasks: no subtasks, one closed subtask, one open subtask, mixture of open and closed subtasks.
  • Created four more tasks: no parents, one closed parent, one open parent, mixture of open and closed parents.
  • Searched for all this stuff, got the proper results:

Screen Shot 2016-07-28 at 10.14.13 AM.png (1×1 px, 222 KB)

Screen Shot 2016-07-28 at 10.11.46 AM.png (1×1 px, 193 KB)

Screen Shot 2016-07-28 at 10.14.07 AM.png (1×1 px, 223 KB)

Screen Shot 2016-07-28 at 10.11.49 AM.png (1×1 px, 193 KB)

Diff Detail

Repository
rP Phabricator
Branch
task1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13170
Build 16858: Run Core Tests
Build 16857: arc lint + arc unit