Page MenuHomePhabricator

Use hovercards in browse dialog
AbandonedPublic

Authored by epriestley on Jun 20 2016, 8:36 PM.
Tags
None
Referenced Files
F13283185: D16154.diff
Sun, Jun 2, 1:03 PM
F13278684: D16154.diff
Sat, Jun 1, 2:32 AM
F13271518: D16154.diff
Thu, May 30, 1:21 AM
F13264421: D16154.diff
Mon, May 27, 4:58 PM
F13258670: D16154.diff
Sun, May 26, 11:45 AM
F13254545: D16154.diff
Sat, May 25, 3:30 AM
F13246176: D16154.id38862.diff
Thu, May 23, 8:20 AM
Unknown Object (File)
May 3 2024, 12:19 PM
Subscribers
None

Details

Summary

Ref T11034. Just proof-of-concept. This doesn't feel completely awful to me, but popping big cards over a small dialog isn't awesome and they can hide the controls, so I don't really love this.

We could possibly pursue this in cojunction with a change that locked the hovercard to the bottom of the dialog, maybe?

+---------------------------+
| (accelerate             ) |
| ...                       |
| ...                       |
| ...                       |
|                [ Cancel ] |
+---------------------------+
  +-----------------------+
  | Hovercard             |
  | Always shows up down  |
  | below here.           |
  +-----------------------+
Test Plan

Screen Shot 2016-06-20 at 1.32.55 PM.png (472×663 px, 61 KB)

Diff Detail

Repository
rP Phabricator
Branch
token1a
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12743
Build 16212: Run Core Tests
Build 16211: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use hovercards in browse dialog.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.