Page MenuHomePhabricator
Differential D14288

Add a CircleCI webhook
ClosedPublic
Actions

Authored by epriestley on Oct 15 2015, 4:38 PM.
Tags
None
Referenced Files
F13267817: D14288.diff
Wed, May 29, 4:16 AM
F13264501: D14288.id34489.diff
Mon, May 27, 5:58 PM
F13253276: D14288.diff
Sat, May 25, 2:33 AM
F13247584: D14288.id35251.diff
Thu, May 23, 8:43 PM
F13241506: D14288.id37365.diff
Wed, May 22, 9:50 PM
F13240266: D14288.id37383.diff
Wed, May 22, 12:29 PM
F13235777: D14288.diff
Tue, May 21, 6:31 AM
F13231515: D14288.diff
Tue, May 21, 12:31 AM
View All Files
Subscribers
dpaola2
• JustinTulloss

Details

Reviewers
chad
Maniphest Tasks
T9456: Evaluate upstream support for third-party build systems
Commits
Restricted Diffusion Commit
rP7868c5d7d0fd: Add a CircleCI webhook
Summary

Ref T9456. This makes everything work, except that CircleCI doesn't fetch tags which are not ancestors of branch heads.

Test Plan

Ran passing builds through CircleCI.

Diff Detail

Repository
rP Phabricator
Branch
circle3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11246
Build 13969: Run Core Tests
Build 13968: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34489.Oct 15 2015, 4:38 PM
epriestley retitled this revision from to Add a CircleCI webhook.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9456: Evaluate upstream support for third-party build systems.
chad accepted this revision.Oct 15 2015, 4:48 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 15 2015, 4:48 PM
epriestley updated this revision to Diff 35251.Nov 25 2015, 3:18 PM
epriestley edited edge metadata.
  • Rebase after possible CircleCI changes.
joshma mentioned this in D14286: Add a "Build with CircleCI" build step.Feb 10 2016, 10:15 PM
• JustinTulloss added a subscriber: • JustinTulloss.Mar 5 2016, 10:46 PM
dpaola2 added a subscriber: dpaola2.Mar 19 2016, 10:16 PM
epriestley updated this revision to Diff 37365.Mar 19 2016, 10:49 PM
  • Rebase.
  • No substantive changes.
epriestley mentioned this in T9456: Evaluate upstream support for third-party build systems.Mar 19 2016, 10:51 PM
epriestley updated this revision to Diff 37383.Mar 22 2016, 7:11 PM
  • Treat "fixed" from CircleCI as a "pass". This status means "previously failed, but now passed" as far as I can tell.
Closed by commit rP7868c5d7d0fd: Add a CircleCI webhook (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2016, 7:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37383

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterCircleCIHookController.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterCircleCIBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildMessage.php

Loading...
Phabricator · Built by Phacility