Page MenuHomePhabricator
Differential D14766

Flesh out Conduit parameter types for Owners + CustomFields
ClosedPublic
Actions

Authored by epriestley on Dec 13 2015, 3:36 PM.
Tags
None
Referenced Files
F13258442: D14766.id35699.diff
Sun, May 26, 9:23 AM
F13248416: D14766.id35705.diff
Fri, May 24, 2:38 AM
F13248415: D14766.diff
Fri, May 24, 2:38 AM
F13226123: D14766.id35705.diff
Sun, May 19, 7:13 PM
F13213590: D14766.diff
Fri, May 17, 7:55 AM
Unknown Object (File)
Tue, May 7, 7:33 AM
Unknown Object (File)
Tue, May 7, 2:04 AM
Unknown Object (File)
Mon, May 6, 3:49 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9964: Fill in Conduit support infrastructure for ApplicationEditor changes
Commits
Restricted Diffusion Commit
rP663dce5029f5: Flesh out Conduit parameter types for Owners + CustomFields
Summary

Ref T9964. Fill in more parameter types and descriptions.

(No date support yet since it's a bit more involved.)

Test Plan

Screen Shot 2015-12-13 at 7.27.07 AM.png (388×708 px, 89 KB)

Diff Detail

Repository
rP Phabricator
Branch
nx8
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:201XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9523
Build 11366: Run Core Tests
Build 11365: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35699.Dec 13 2015, 3:36 PM
epriestley retitled this revision from to Flesh out Conduit parameter types for Owners + CustomFields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.
chad accepted this revision.Dec 13 2015, 4:14 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2015, 4:14 PM
epriestley updated this revision to Diff 35705.Dec 13 2015, 6:22 PM
epriestley edited edge metadata.
  • Pick up unit test fix.
Closed by commit rP663dce5029f5: Flesh out Conduit parameter types for Owners + CustomFields (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2015, 12:23 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form.Sep 21 2016, 2:23 PM
epriestley mentioned this in D16582: Make "text" custom fields appear in ApplicationSearch again.Sep 21 2016, 9:35 PM
epriestley mentioned this in rP8941bbfcea7d: Make "text" custom fields appear in ApplicationSearch again.Sep 21 2016, 11:39 PM

Revision Contents
Changeset List

Diff 35705

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitBoolParameterType.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitEpochParameterType.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitIntParameterType.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitStringParameterType.php

Loading...
View Options

src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchCustomFieldProxyField.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchDatasourceField.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php

Loading...
Phabricator · Built by Phacility