Page MenuHomePhabricator
Differential D13616

Fully modularize Herald field values
ClosedPublic
Actions

Authored by epriestley on Jul 9 2015, 8:32 PM.
Tags
None
Referenced Files
F13314650: D13616.diff
Tue, Jun 11, 10:45 PM
F13311700: D13616.diff
Tue, Jun 11, 5:22 AM
F13311366: D13616.id32973.diff
Tue, Jun 11, 3:52 AM
F13298618: D13616.diff
Fri, Jun 7, 7:01 AM
F13282771: D13616.diff
Sun, Jun 2, 12:25 PM
F13278631: D13616.diff
Sat, Jun 1, 12:53 AM
F13268080: D13616.diff
Wed, May 29, 4:36 AM
F13253571: D13616.diff
Sat, May 25, 2:46 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP715233fb6115: Fully modularize Herald field values
Summary

Ref T8726. This gets rid of all the VALUE_* constants and lets Fields provide arbitrary typeaheads without upstream/JS changes.

Test Plan

Used all tokenizers. Used "Another Herald Rule". Grepped for all removed constants.

Diff Detail

Repository
rP Phabricator
Branch
herald4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7233
Build 7508: [Placeholder Plan] Wait for 30 Seconds
Build 7507: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32898.Jul 9 2015, 8:32 PM
epriestley retitled this revision from to Fully modularize Herald field values.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 9 2015, 8:33 PM
btrahan accepted this revision.Jul 16 2015, 8:42 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:42 PM
Closed by commit rP715233fb6115: Fully modularize Herald field values (authored by epriestley, committed by epriestley). · Explain WhyJul 16 2015, 9:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
src/
2 lines
applications/
differential/
herald/
4 lines
10 lines
10 lines
10 lines
4 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
diffusion/
herald/
10 lines
2 lines
10 lines
10 lines
10 lines
10 lines
4 lines
10 lines
10 lines
10 lines
10 lines
10 lines
10 lines
4 lines
11 lines
4 lines
10 lines
10 lines
10 lines
4 lines
11 lines
4 lines
10 lines
herald/
adapter/
50 lines
controller/
37 lines
field/
2 lines
7 lines
21 lines
value/
2 lines
14 lines
2 lines
2 lines
60 lines
maniphest/
herald/
10 lines
4 lines
4 lines
4 lines
metamta/
herald/
10 lines
pholio/
herald/
4 lines
phriction/
herald/
4 lines
project/
herald/
10 lines
spaces/
herald/
4 lines
subscriptions/
herald/
10 lines
infrastructure/
customfield/
standard/
4 lines
webroot/
rsrc/
js/
application/
herald/
81 lines

Diff 32898

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/herald/DifferentialDiffAuthorHeraldField.php

Loading...
View Options

src/applications/differential/herald/DifferentialDiffAuthorProjectsHeraldField.php

Loading...
View Options

src/applications/differential/herald/DifferentialDiffRepositoryHeraldField.php

Loading...
View Options

src/applications/differential/herald/DifferentialDiffRepositoryProjectsHeraldField.php

Loading...
View Options

src/applications/differential/herald/DifferentialRevisionAuthorHeraldField.php

Loading...
View Options

src/applications/differential/herald/DifferentialRevisionAuthorProjectsHeraldField.php

Loading...
View Options

src/applications/differential/herald/DifferentialRevisionPackageHeraldField.php

Loading...
View Options

src/applications/differential/herald/DifferentialRevisionPackageOwnerHeraldField.php

Loading...
View Options

src/applications/differential/herald/DifferentialRevisionRepositoryHeraldField.php

Loading...
View Options

src/applications/differential/herald/DifferentialRevisionRepositoryProjectsHeraldField.php

Loading...
View Options

src/applications/differential/herald/DifferentialRevisionReviewersHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitAuthorHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitCommitterHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitPackageAuditHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitPackageHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitPackageOwnerHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitRepositoryHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitRepositoryProjectsHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitReviewerHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitRevisionReviewersHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitRevisionSubscribersHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentAuthorHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentCommitterHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentPusherHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentPusherProjectsHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentRepositoryHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentRepositoryProjectsHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentRevisionReviewersHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentRevisionSubscribersHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitRefPusherHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitRefPusherProjectsHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitRefRepositoryHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitRefRepositoryProjectsHeraldField.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/field/HeraldAlwaysField.php

Loading...
View Options

src/applications/herald/field/HeraldAnotherRuleField.php

Loading...
View Options

src/applications/herald/field/HeraldField.php

Loading...
View Options

src/applications/herald/value/HeraldEmptyFieldValue.php

Loading...
View Options

src/applications/herald/value/HeraldFieldValue.php

Loading...
View Options

src/applications/herald/value/HeraldSelectFieldValue.php

Loading...
View Options

src/applications/herald/value/HeraldTextFieldValue.php

Loading...
View Options

src/applications/herald/value/HeraldTokenizerFieldValue.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskAssigneeHeraldField.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskAuthorHeraldField.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskPriorityHeraldField.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskStatusHeraldField.php

Loading...
View Options

src/applications/metamta/herald/PhabricatorMetaMTAApplicationEmailHeraldField.php

Loading...
View Options

src/applications/pholio/herald/PholioMockAuthorHeraldField.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentAuthorHeraldField.php

Loading...
View Options

src/applications/project/herald/HeraldProjectsField.php

Loading...
View Options

src/applications/spaces/herald/HeraldSpaceField.php

Loading...
View Options

src/applications/subscriptions/herald/HeraldSubscribersField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php

Loading...
View Options

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

Loading...
Phabricator · Built by Phacility