Page MenuHomePhabricator

Modularize all Herald pre-commit ref fields
ClosedPublic

Authored by epriestley on Jul 8 2015, 10:40 AM.
Tags
None
Referenced Files
F13279118: D13600.diff
Sat, Jun 1, 11:13 AM
F13269731: D13600.id32868.diff
Wed, May 29, 7:10 AM
F13266102: D13600.id32869.diff
Tue, May 28, 9:09 AM
F13242907: D13600.id32868.diff
Thu, May 23, 3:12 AM
F13235356: D13600.id32868.diff
Tue, May 21, 4:46 AM
F13235342: D13600.id32870.diff
Tue, May 21, 4:45 AM
F13235341: D13600.id32869.diff
Tue, May 21, 4:45 AM
F13231474: D13600.diff
Tue, May 21, 12:29 AM
Subscribers

Details

Summary

Ref T8726. Just (pre-commit content) one more left.

Test Plan
  • Created a big rule with every field.
  • Migrated it.
  • Verified the rule was still the same.
  • Pushed a bunch of changes and reviewed the transcripts.

Diff Detail

Repository
rP Phabricator
Branch
hmodular13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7210
Build 7464: [Placeholder Plan] Wait for 30 Seconds
Build 7463: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize all Herald pre-commit ref fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Also handle special rendering of "Change" rule.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/herald/adapter/HeraldAdapter.php
1215–1222

nice

This revision is now accepted and ready to land.Jul 8 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.