Page MenuHomePhabricator
Differential D13171

Support PhabricatorSpacesInterface in ApplicationSearch UI
ClosedPublic
Actions

Authored by epriestley on Jun 5 2015, 5:10 PM.
Tags
None
Referenced Files
F13274153: D13171.diff
Fri, May 31, 3:21 AM
F13265340: D13171.id31832.diff
Tue, May 28, 3:25 AM
F13260152: D13171.diff
Sun, May 26, 11:33 PM
F13244385: D13171.diff
Thu, May 23, 4:46 AM
F13243594: D13171.id.diff
Thu, May 23, 4:03 AM
F13231842: D13171.id31833.diff
Tue, May 21, 12:48 AM
F13231841: D13171.id31832.diff
Tue, May 21, 12:48 AM
F13228015: D13171.id31833.diff
Mon, May 20, 6:17 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8441: Integrate Spaces into ApplicationSearch
Commits
Restricted Diffusion Commit
rPb5dfd34e4a89: Support PhabricatorSpacesInterface in ApplicationSearch UI
Summary

Ref T8441. Does what it says, provided other conditions (like using the new SearchField stuff) are fulfilled.

Test Plan

Screen Shot 2015-06-05 at 10.09.29 AM.png (940×1 px, 153 KB)

Screen Shot 2015-06-05 at 10.09.30 AM.png (940×1 px, 158 KB)

Diff Detail

Repository
rP Phabricator
Branch
spaces11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6574
Build 6596: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31832.Jun 5 2015, 5:10 PM
epriestley retitled this revision from to Support PhabricatorSpacesInterface in ApplicationSearch UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8441: Integrate Spaces into ApplicationSearch.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 5 2015, 5:10 PM
epriestley updated this revision to Diff 31833.Jun 5 2015, 5:11 PM
  • Fix a warning when no spaces exist yet.
btrahan accepted this revision.Jun 5 2015, 6:19 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2015, 6:19 PM
Closed by commit rPb5dfd34e4a89: Support PhabricatorSpacesInterface in ApplicationSearch UI (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2015, 6:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31832

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchSpacesField.php

Loading...
View Options

src/applications/spaces/phid/PhabricatorSpacesNamespacePHIDType.php

Loading...
View Options

src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php

Loading...
View Options

src/applications/spaces/typeahead/PhabricatorSpacesNamespaceDatasource.php

Loading...
Phabricator · Built by Phacility