Page MenuHomePhabricator
Differential D12460

Implement a project logic datasource
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 5:23 PM.
Tags
None
Referenced Files
F13293802: D12460.diff
Wed, Jun 5, 1:24 PM
F13279071: D12460.diff
Sat, Jun 1, 10:39 AM
F13249115: D12460.id.diff
Fri, May 24, 6:48 AM
F13235814: D12460.id29904.diff
Tue, May 21, 6:42 AM
F13231147: D12460.diff
Tue, May 21, 12:13 AM
F13213040: D12460.diff
Fri, May 17, 7:18 AM
F13174571: D12460.diff
Tue, May 7, 11:55 PM
Unknown Object (File)
Apr 28 2024, 2:26 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5595: Allow all applications to filter results by project
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rPc2fc065bfb3c: Implement a project logic datasource
Summary

Ref T4100. Ref T5595. This allows you to execute all "Projects", "Any Project", "Not in projects" and "include no projects" operations in one field.

It doesn't actually implement such a field yet.

Test Plan

Screen_Shot_2015-04-18_at_10.21.56_AM.png (447×619 px, 43 KB)

Diff Detail

Repository
rP Phabricator
Branch
logic8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5371
Build 5389: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29904.Apr 18 2015, 5:23 PM
epriestley retitled this revision from to Implement a project logic datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T4100: Support query parameterization in typeaheads, T5595: Allow all applications to filter results by project.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2015, 5:23 PM
btrahan accepted this revision.Apr 20 2015, 4:40 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 4:40 PM
Closed by commit rPc2fc065bfb3c: Implement a project logic datasource (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29904

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalAndDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalOrNotDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Loading...
Phabricator · Built by Phacility