Page MenuHomePhabricator
Differential D12439

Uncheat Macro datasource browse support
ClosedPublic
Actions

Authored by epriestley on Apr 16 2015, 7:14 PM.
Tags
None
Referenced Files
F13243257: D12439.diff
Thu, May 23, 3:38 AM
F13240851: D12439.id.diff
Wed, May 22, 5:11 PM
F13238223: D12439.id29854.diff
Tue, May 21, 6:04 PM
F13238180: D12439.id29882.diff
Tue, May 21, 5:39 PM
F13227229: D12439.id29882.diff
Mon, May 20, 1:54 AM
F13221606: D12439.diff
Sun, May 19, 2:54 AM
F13219582: D12439.id29854.diff
Sat, May 18, 7:34 PM
F13217295: D12439.diff
Sat, May 18, 4:22 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5750: Implement typeahead browse mode
Commits
Restricted Diffusion Commit
rPba48e05964d4: Uncheat Macro datasource browse support
Summary

Ref T5750. Macro browse support is actually useful (in the meme dialog) and fairly straightforward to implement.

Test Plan
  • Browsed macros.
  • Queired macros.

Diff Detail

Repository
rP Phabricator
Branch
type11
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5341
Build 5359: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29854.Apr 16 2015, 7:14 PM
epriestley retitled this revision from to Uncheat Macro datasource browse support.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5750: Implement typeahead browse mode.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 16 2015, 7:14 PM
btrahan accepted this revision.Apr 16 2015, 9:18 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 16 2015, 9:18 PM
Closed by commit rPba48e05964d4: Uncheat Macro datasource browse support (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2015, 6:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
query/
42 lines
23 lines
typeahead/
23 lines
search/
engine/
22 lines

Diff 29854

View Options

src/applications/macro/query/PhabricatorMacroQuery.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/macro/typeahead/PhabricatorMacroDatasource.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
Phabricator · Built by Phacility