Page MenuHomePhabricator

Improve browsability of People query
ClosedPublic

Authored by epriestley on Apr 15 2015, 6:31 PM.
Tags
None
Referenced Files
F13241283: D12427.id29876.diff
Wed, May 22, 7:59 PM
F13241010: D12427.id.diff
Wed, May 22, 6:31 PM
F13240763: D12427.id29836.diff
Wed, May 22, 4:22 PM
F13218939: D12427.id.diff
Sat, May 18, 1:56 PM
F13217674: D12427.diff
Sat, May 18, 7:00 AM
F13188120: D12427.diff
Sat, May 11, 5:03 AM
Unknown Object (File)
Tue, May 7, 8:14 AM
Unknown Object (File)
Fri, May 3, 7:57 AM
Subscribers

Details

Summary

Ref T5750. Fix this query so it works better with the browse view. In particular, make it return results before the user types a query.

Test Plan
  • Used a people tokenizer.
  • Used global search tokenizer to search for people.
  • Ran new version of query in production to make sure it wasn't crazy.
  • Browsed through results in browse view.

Diff Detail

Repository
rP Phabricator
Branch
type5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5328
Build 5346: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve browsability of People query.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/people/query/PhabricatorPeopleQuery.php
329–347

BEHOLD! Adding new sort orders is now a reasonable thing which mere mortals can accomplish!

btrahan edited edge metadata.
btrahan added inline comments.
src/applications/people/query/PhabricatorPeopleQuery.php
329–347

lol

This revision is now accepted and ready to land.Apr 15 2015, 6:48 PM
This revision was automatically updated to reflect the committed changes.