Page MenuHomePhabricator
Differential D12424

Make browse view show tokens instead of raw data
ClosedPublic
Actions

Authored by epriestley on Apr 15 2015, 4:19 PM.
Tags
None
Referenced Files
F13293031: D12424.id29833.diff
Wed, Jun 5, 6:24 AM
F13281052: D12424.diff
Sun, Jun 2, 9:40 AM
F13273561: D12424.id29833.diff
Fri, May 31, 2:07 AM
F13268023: D12424.diff
Wed, May 29, 4:31 AM
F13256787: D12424.id29833.diff
Sat, May 25, 5:29 PM
F13253507: D12424.diff
Sat, May 25, 2:43 AM
F13246777: D12424.diff
Thu, May 23, 1:50 PM
F13241891: D12424.id29833.diff
Thu, May 23, 12:06 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5750: Implement typeahead browse mode
Commits
Restricted Diffusion Commit
rP6a4de406b8fc: Make browse view show tokens instead of raw data
Summary

Ref T5750. Move the server-side token rendering code to a shared location and use it in the browse view.

Test Plan

Screen_Shot_2015-04-15_at_9.16.09_AM.png (1×1 px, 172 KB)

Diff Detail

Repository
rP Phabricator
Branch
type2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5325
Build 5343: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29833.Apr 15 2015, 4:19 PM
epriestley retitled this revision from to Make browse view show tokens instead of raw data.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5750: Implement typeahead browse mode.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 15 2015, 4:19 PM
btrahan accepted this revision.Apr 15 2015, 5:14 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2015, 5:14 PM
Closed by commit rP6a4de406b8fc: Make browse view show tokens instead of raw data (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2015, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29833

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/meta/phid/PhabricatorApplicationApplicationPHIDType.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

src/applications/typeahead/storage/PhabricatorTypeaheadResult.php

Loading...
View Options

src/applications/typeahead/view/PhabricatorTypeaheadTokenView.php

Loading...
View Options

src/view/control/AphrontTokenizerTemplateView.php

Loading...
Phabricator · Built by Phacility