Page MenuHomePhabricator

Provide "builtin" high-level result orders
ClosedPublic

Authored by epriestley on Apr 12 2015, 10:34 PM.
Tags
None
Referenced Files
F13241354: D12379.id29721.diff
Wed, May 22, 8:32 PM
F13241013: D12379.id29768.diff
Wed, May 22, 6:33 PM
F13240758: D12379.id29722.diff
Wed, May 22, 4:20 PM
F13240484: D12379.id.diff
Wed, May 22, 2:32 PM
F13239949: D12379.id29721.diff
Wed, May 22, 8:29 AM
F13236240: D12379.diff
Tue, May 21, 8:53 AM
F13217666: D12379.diff
Sat, May 18, 6:57 AM
F13186641: D12379.diff
Sat, May 11, 3:46 AM
Subscribers

Details

Summary

Ref T7803. Currently, available high-level orders are spread across Query and SearchEngine classes and implemented separately for each application.

Lift the concept of "builtin" (high-level, user-facing, named) orders (similar to "builtin" queries in ApplicationSearch) into the root Query class, and let it drive the SearchEngine implementation. This allows you to define a new order in one place and have it automatically work across the entire stack.

This will also let Conduit expose this information in a straightforward way.

Test Plan
  • Used ApplicationSearch in Diffusion.
  • Used all result orderings.

Diff Detail

Repository
rP Phabricator
Branch
rpaging17
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5270
Build 5288: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Provide "builtin" high-level result orders.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:58 PM
This revision was automatically updated to reflect the committed changes.