Page MenuHomePhabricator

Modernize more paging/order queries
ClosedPublic

Authored by epriestley on Apr 12 2015, 6:55 PM.
Tags
None
Referenced Files
F13271402: D12371.diff
Wed, May 29, 10:48 PM
F13262882: D12371.diff
Mon, May 27, 4:40 AM
F13251165: D12371.id29767.diff
Fri, May 24, 8:46 PM
F13241280: D12371.id29767.diff
Wed, May 22, 7:56 PM
F13240875: D12371.id29699.diff
Wed, May 22, 5:27 PM
F13240537: D12371.id.diff
Wed, May 22, 2:56 PM
F13217353: D12371.diff
Sat, May 18, 4:45 AM
F13212477: D12371.diff
Fri, May 17, 6:45 AM
Subscribers

Details

Summary

Ref T7803. Removes some getReversePaging().

This also fixes null column handling, by adding an explicit 'null' key with possible values "head" (put NULL before other values) or "tail" (put NULL after other values).

Maniphest has some glitchiness in paging through NULLs right now, but I believe it's all pre-existing and will be resolved when it fully converts. Diffusion is fully converted and pages through NULL correctly.

Test Plan
  • Failed to identify any reason for ChangesetQuery to reverse paging.
  • Paged thorugh Diffusion.
  • Paged through Maniphest.
    • Maniphest has some issues when paging inside a NULL section, but these issues are preexisting and will be resolved later in this change sequence.

Diff Detail

Repository
rP Phabricator
Branch
rpaging14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5255
Build 5273: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Modernize more paging/order queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:32 PM
This revision was automatically updated to reflect the committed changes.