Page MenuHomePhabricator

Improve handle semantics with HandlePool / HandleList
ClosedPublic

Authored by epriestley on Mar 30 2015, 1:27 AM.
Tags
None
Referenced Files
F13290612: D12202.diff
Tue, Jun 4, 7:10 PM
F13288610: D12202.diff
Tue, Jun 4, 10:41 AM
F13285391: D12202.id29352.diff
Mon, Jun 3, 8:01 PM
F13267035: D12202.id29325.diff
Wed, May 29, 12:02 AM
F13241324: D12202.id29352.diff
Wed, May 22, 8:20 PM
F13240761: D12202.id29325.diff
Wed, May 22, 4:21 PM
F13240725: D12202.id.diff
Wed, May 22, 4:05 PM
F13235415: D12202.id29352.diff
Tue, May 21, 5:11 AM
Subscribers
Tokens
"Grey Medal" token, awarded by chad.

Details

Summary

Ref T7689, which discusses some of the motivation here. Briefly, these methods are awkward:

  • Controller->loadHandles()
  • Controller->loadViewerHandles()
  • Controller->renderHandlesForPHIDs()

This moves us toward better semantics, less awkwardness, and a more reasonable attack on T7688 which won't double-fetch a bunch of data.

Test Plan
  • Added unit tests.
  • Converted one controller to the new stuff.
    • Viewed countdown lists, saw handles render.

Diff Detail

Repository
rP Phabricator
Branch
param1
Lint
Lint Errors
Unit
Tests Passed
Build Status
Buildable 5033
Build 5051: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve handle semantics with HandlePool / HandleList.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.