Page MenuHomePhabricator
Differential D9878

Modernize "build plans" typeahead datasource
ClosedPublic
Actions

Authored by epriestley on Jul 10 2014, 9:09 PM.
Tags
None
Referenced Files
F13295713: D9878.diff
Thu, Jun 6, 7:18 AM
F13295273: D9878.diff
Thu, Jun 6, 12:29 AM
F13281425: D9878.diff
Sun, Jun 2, 10:48 AM
F13271864: D9878.diff
Thu, May 30, 6:15 AM
F13266008: D9878.id.diff
Tue, May 28, 8:04 AM
F13244716: D9878.diff
Thu, May 23, 5:16 AM
F13194425: D9878.diff
Sun, May 12, 9:33 PM
F13183099: D9878.id23729.diff
Fri, May 10, 6:57 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rPdba48656817f: Modernize "build plans" typeahead datasource
Summary

Ref T4420. Modernize build plans.

Test Plan
  • Used build plan typeahead in Harbormaster.

Diff Detail

Repository
rP Phabricator
Branch
tok5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1616
Build 1617: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23717.Jul 10 2014, 9:09 PM
epriestley retitled this revision from to Modernize "build plans" typehaead datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4420: Modernize typeahead datasources.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 10 2014, 9:09 PM
Harbormaster completed remote builds in B1616: Diff 23717.Jul 10 2014, 9:10 PM
joshuaspence retitled this revision from Modernize "build plans" typehaead datasource to Modernize "build plans" typeahead datasource.Jul 10 2014, 10:11 PM
btrahan accepted this revision.Jul 10 2014, 10:32 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 10 2014, 10:32 PM
epriestley closed this revision.Jul 10 2014, 11:21 PM
epriestley updated this revision to Diff 23729.

Closed by commit rPdba48656817f (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
harbormaster/
phid/
9 lines
typeahead/
32 lines
herald/
controller/
2 lines
typeahead/
controller/
15 lines

Diff 23717

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterPHIDTypeBuildPlan.php

Loading...
View Options

src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
Phabricator · Built by Phacility