Page MenuHomePhabricator

Modernize "macro" typeahead datasource
ClosedPublic

Authored by epriestley on Jul 10 2014, 8:43 PM.
Tags
None
Referenced Files
F13223060: D9875.diff
Sun, May 19, 4:14 AM
F13220039: D9875.diff
Sat, May 18, 10:52 PM
F13215927: D9875.id23726.diff
Fri, May 17, 8:57 PM
F13209545: D9875.id23726.diff
Fri, May 17, 12:52 AM
F13202556: D9875.id.diff
Tue, May 14, 10:49 PM
F13183117: D9875.id23714.diff
Fri, May 10, 6:58 AM
F13183116: D9875.id23726.diff
Fri, May 10, 6:58 AM
F13183115: D9875.id23713.diff
Fri, May 10, 6:58 AM
Subscribers

Details

Summary

Ref T4420. Make this modern.

Test Plan
  • Used typeahead in remarkup comment area to select macro "derpdog".

Diff Detail

Repository
rP Phabricator
Branch
tok2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1613
Build 1614: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Modernize "macro" typeahead datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Forgot to save file removing this from common typehead.
btrahan edited edge metadata.

I think I'm learning about the nitty gritty of how this icon stuff works over these diffs.

src/applications/macro/typeahead/PhabricatorMacroDatasource.php
29

oh, I guess if you want the color you have to specify it here too?

This revision is now accepted and ready to land.Jul 10 2014, 10:34 PM

The icon stuff is dumb right now, my end-of-this-sequence plan is to make Results go look up the PHIDType and use the icon/color on that, if one isn't provided. That will delete 90% of the code and just leave a couple of special cases (mostly projects). For now, I'm just moving the code into modular datasources without touching it too much.

epriestley updated this revision to Diff 23726.

Closed by commit rPa2caea13d65f (authored by @epriestley).