Page MenuHomePhabricator
Differential D9177

Make "Facts" publicly viewable
ClosedPublic
Actions

Authored by epriestley on May 18 2014, 4:07 AM.
Tags
None
Referenced Files
F13265934: D9177.diff
Tue, May 28, 7:13 AM
F13238694: D9177.id.diff
Tue, May 21, 8:41 PM
F13229133: D9177.id21796.diff
Mon, May 20, 2:38 PM
F13217000: D9177.id21853.diff
Sat, May 18, 3:22 AM
F13215852: D9177.id21853.diff
Fri, May 17, 8:22 PM
F13214314: D9177.diff
Fri, May 17, 9:51 AM
F13198040: D9177.diff
Mon, May 13, 2:59 AM
F13174475: D9177.diff
Tue, May 7, 11:21 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4830: Applications with Public permissions requiring users to login
Commits
Restricted Diffusion Commit
rPba6a5dae6156: Make "Facts" publicly viewable
Summary

Ref T4830. Also deletes some very obsolete code.

Test Plan

Looked at Facts as logged out user.

Diff Detail

Repository
rP Phabricator
Branch
factpub
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 544
Build 544: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21796.May 18 2014, 4:07 AM
epriestley retitled this revision from to Make "Facts" publicly viewable.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4830: Applications with Public permissions requiring users to login.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 18 2014, 4:07 AM
Harbormaster completed remote builds in B544: Diff 21796.May 18 2014, 4:08 AM
btrahan accepted this revision.May 19 2014, 6:21 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:21 PM
epriestley closed this revision.May 19 2014, 7:39 PM
epriestley updated this revision to Diff 21853.

Closed by commit rPba6a5dae6156 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
fact/
application/
4 lines
controller/
10 lines
13 lines
12 lines

Diff 21796

View Options

src/applications/fact/application/PhabricatorApplicationFact.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactChartController.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactController.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactHomeController.php

Loading...
Phabricator · Built by Phacility