Page MenuHomePhabricator
Create Task
Maniphest T9319

Accessing image file in Diffusion must not generate error (unhandled exception)
Closed, ResolvedPublic
Actions

Description

When accessing an image file (tested PNG and JPG) through Diffusion in order to show it in the browser an unhandled exception is thrown.

Unhandled Exception ("PhutilProxyException")	
Host returned HTTP/200, but invalid JSON data in response to a Conduit method call.

Environment: Chrome 45.x on OSX 10.10.5
Note: This happened on our (SaaS) Phabricator instance on phacility.com

Screen Shot 2015-09-02 at 11.27.02.png (488×790 px, 70 KB)

Revisions and Commits

rP Phabricator
D14970rPd1fb2f7fb96d Make `diffusion.filecontentquery` return file PHIDs instead of raw content
D14969rPda3963b009ce Convert a low-level VCS query in Diff extraction to a Conduit call
D14968rP413ca12fda6b Move commit attachment to a separate CLI command
D14967rP0dd947cceddc Move diff extraction from commits to a separate test with a CLI command
D14958rP9728c65e9358 Drive blame generation through `diffusion.blame`

Related Objects
Search...

Event Timeline

CaptSpot created this task.Sep 2 2015, 9:32 AM
CaptSpot assigned this task to epriestley.
CaptSpot updated the task description. (Show Details)
CaptSpot added a project: Support.
CaptSpot changed the visibility from "Public (No Login Required)" to "All Users".
CaptSpot added a subscriber: CaptSpot.
CaptSpot updated the task description. (Show Details)Sep 2 2015, 10:27 AM
chad changed the visibility from "All Users" to "Public (No Login Required)".Sep 2 2015, 2:29 PM
epriestley added a comment.Sep 2 2015, 2:30 PM

Thanks for the report! I'll take a look at this.

I suspect the root issue is that we're trying to JSON-encode non-UTF data because of the repository service configuration in the cluster. This might require a partial fix of T5955, although I think I had some plans to just change how this API works (to return a reference to a file rather than the raw file data, which could be better for a number of reasons) so that might be a simpler approach.

We can also generally improve the error behavior here.

epriestley triaged this task as Normal priority.Sep 2 2015, 2:30 PM
epriestley edited projects, added Phacility Support, Conduit, Diffusion, Files; removed Support.
epriestley added a project: Phacility.
epriestley moved this task from Backlog to Onboarding/NUX on the Phacility board.
chad added a subscriber: chad.Sep 2 2015, 2:31 PM
epriestley added a parent task: T9303: Improve Phacility Onboarding/NUX.Sep 2 2015, 2:31 PM
epriestley mentioned this in T9303: Improve Phacility Onboarding/NUX.
joshuaspence added a subscriber: joshuaspence.Sep 2 2015, 8:39 PM
• ivan-1986 closed subtask Restricted Maniphest Task as Spite.Sep 13 2015, 9:59 AM
epriestley moved this task from Backlog to vNext on the Diffusion board.Oct 20 2015, 1:25 PM
epriestley mentioned this in T3141: Improve general stability/sanity of Diffusion file content queries.Oct 20 2015, 2:12 PM
epriestley removed a project: Files.Nov 24 2015, 4:59 PM
epriestley mentioned this in T4209: Multiserver / High-Availability Configuration.Dec 4 2015, 12:20 PM
epriestley removed a project: Conduit.Dec 8 2015, 10:51 PM
epriestley added a subscriber: epriestley.
epriestley mentioned this in D14957: Implement a dedicated "diffusion.blame" API method.Jan 6 2016, 1:17 PM
epriestley added a revision: D14958: Drive blame generation through `diffusion.blame`.Jan 6 2016, 2:20 PM
epriestley mentioned this in rPf561dc172d49: Implement a dedicated "diffusion.blame" API method.Jan 6 2016, 5:24 PM
epriestley added a commit: rP9728c65e9358: Drive blame generation through `diffusion.blame`.
epriestley added a revision: D14967: Move diff extraction from commits to a separate test with a CLI command.Jan 8 2016, 12:42 PM
epriestley added a revision: D14968: Move commit attachment to a separate CLI command.Jan 8 2016, 1:39 PM
epriestley added a revision: D14969: Convert a low-level VCS query in Diff extraction to a Conduit call.Jan 8 2016, 1:53 PM
epriestley added a revision: D14970: Make `diffusion.filecontentquery` return file PHIDs instead of raw content.Jan 8 2016, 2:07 PM
epriestley added a commit: rP0dd947cceddc: Move diff extraction from commits to a separate test with a CLI command.Jan 8 2016, 5:22 PM
epriestley closed this task as Resolved by committing rPd1fb2f7fb96d: Make `diffusion.filecontentquery` return file PHIDs instead of raw content.Jan 8 2016, 5:28 PM
epriestley added a commit: rP413ca12fda6b: Move commit attachment to a separate CLI command.
epriestley added a commit: rPda3963b009ce: Convert a low-level VCS query in Diff extraction to a Conduit call.
epriestley added a commit: rPd1fb2f7fb96d: Make `diffusion.filecontentquery` return file PHIDs instead of raw content.
Phabricator · Built by Phacility