Page MenuHomePhabricator
Create Task
Maniphest T4211

Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234"
Closed, DuplicatePublic
Actions

Description

Noticed the difference between rP4c143ad3b2c4bb6e9d15e2eefda5432455fc3a9a and rPccd4ae56382762fa2631e1c0a521e4ebaa5f2926.

The first one appears on T4205 because it contains "Ref T4205" in the summary. The latter one does not appear, even though it has "Maniphest Tasks: T4205" in it (the first one has this as well).

Generally I think commits should be picked up by the task if the diff they reference is associated so that there isn't inconsistent behaviour (it also means that all diffs that are associated with a task that get closed off get the nice "D1234 / rP4c143ad3" format).

Related Objects
Search...

Event Timeline

hach-que created this task.Dec 7 2013, 6:46 AM
hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Maniphest.
hach-que added subscribers: hach-que, epriestley.
epriestley added a comment.Dec 8 2013, 4:22 PM

This whole thing needs some work; see also T3906 / T3577.

chad moved this task from column2 to Backlog on the Maniphest board.May 20 2014, 4:58 AM
joshuaspence added a subscriber: joshuaspence.May 20 2014, 8:50 AM
epriestley edited this Maniphest Task.May 24 2014, 1:02 PM
epriestley triaged this task as Low priority.May 24 2014, 1:02 PM
eadler added a subscriber: eadler.Jul 15 2015, 3:01 AM
epriestley moved this task from Backlog to Task Relationships on the Maniphest board.Dec 22 2015, 1:01 AM
epriestley merged a task: T10062: Automaticaly add a task to a commit, if task was added to differential revision.Dec 29 2015, 3:49 AM
epriestley added a subscriber: Luke081515.2.
Luke081515.2 added a subscriber: chad.Jun 15 2016, 9:02 PM

@chad some of your commits are affected too, for example rP695f0b09b23761c813b015c2b62075cbdee1de59, better if you add for example a Ref T99999 ;)

epriestley closed subtask T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure as Wontfix.Jan 18 2017, 6:39 PM
epriestley added a parent task: T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".Nov 21 2019, 4:03 PM

T13463 is approximately the same as this, but now ripe; I'm going to merge this there.

Herald added a subscriber: amckinley. · View Herald TranscriptNov 21 2019, 4:04 PM
epriestley closed this task as a duplicate of T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".Nov 21 2019, 4:05 PM
epriestley removed a subtask: T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure.
Phabricator · Built by Phacility