Differential: Inlines and View Options
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Apr 17 2020, 3:11 PM

Description

Completed

The "Open in Editor" keyboard shortcut currently requires a file to be focused, but can also function with a comment focused. (In this case, it should try to jump to that line.)
In Diffusion, when viewing a single file, the "\" keystroke could be bound to "Open in Editor".
Editor URIs don't support repository short names.
Editor URIs should explicitly forbid "/../" from appearing in paths to prevent hyjinx.
I think loadEditorLink() currently relies incorrectly on the behavior of strtr() being magical / reading minds.
See PHI1661, which would like a keyboard shortcut for "Open in Editor".
See PHI1659, which would like the "do not show unchanged files with no comments in intradiffs" rule to improve to "do not show unchanged files with no non-hidden comments in intradiffs".
The "View As..." engine selector doesn't omit engines which can't render diffs.

Revisions and Commits

rP Phabricator
	Abandoned		D21145 Remove the very janky URI-based "Saved Changes" code
		D21149	rPef69c7969f58 Restore editor behavior to Diffusion and support "\" shortcut
		D21148	rP537ff68edda2 In Differential, make the "Open in Editor" keystroke work with no selection, or…
		D21147	rPf02024615ad3 Add "short name", "id", and "phid" variables for external editor URIs
		D21146	rPc79094d7a8bd Add static errors, supported protocols, and a dynamic function listing to…
		D21144	rP7a79131bf279 Replace old hard-coded URI-based "changes saved" jank with new overgeneralized…
		D21143	rP3984c14260d3 Tokenize external editor links so they can be safely materialized on the client
		D21142	rP416833561903 Remove the "Edit Multiple Files" external editor setting
		D21141	rP8bdc7133521d Make the "Keyboard Shortcuts" dialog in Differential less hideous
		D21140	rP84cd4a385450 Move "External Editor" settings to a separate settings group
		D21136	rP3adf082002aa When inlines would disable a file shield in a diff, still apply the shield if…
		D21135	rP3d966d8a41f1 Add an "Open in External Editor" keystroke to Differential

Related Objects
Search...

Status	Assigned	Task
Resolved	epriestley	T13515 Differential: Inlines and View Options
Open	epriestley	T13514 Restore the Differential "minimap" element
Resolved	epriestley	T13513 Make schema changes to inlines to prepare for new inline features
Resolved	epriestley	T13455 Make "View Options" in Differential sticky across reloads
Resolved	epriestley	T13516 Remove the "filetree" setting (so it's always enabled for everyone)
Open	epriestley	T13519 Support collapsing folders in the diff paths panel
Open	epriestley	T13520 Update the diff table of contents for moved files, long paths, etc
Open	epriestley	T13521 FormationView could do more Javascript magic around device layouts and header elements
Open	epriestley	T13523 Update logic around intradiff changesets to better handle binary files, header information, and attributes

Event Timeline

epriestley triaged this task as Normal priority.Apr 17 2020, 3:11 PM

epriestley created this task.

Herald added a subscriber: amckinley. · View Herald TranscriptApr 17 2020, 3:11 PM

epriestley added subtasks: T13514: Restore the Differential "minimap" element, T13513: Make schema changes to inlines to prepare for new inline features, T13455: Make "View Options" in Differential sticky across reloads.Apr 17 2020, 3:11 PM

epriestley updated the task description. (Show Details)

keyboard shortcut for "Open in Editor".

Safari now prompts you with this dialog every time a page opens an external application:

Screen Shot 2020-04-17 at 8.26.10 AM.png (133×469 px, 17 KB)

This can be avoided by dragging an <a href="..."> link from the webpage into the Textmate app in the dock, and presumably likewise for other applications. This might motivate making "Open in Editor" a top-level icon, at least on desktop for users who have configured an external editor.

epriestley added a revision: D21135: Add an "Open in External Editor" keystroke to Differential.Apr 17 2020, 4:52 PM

epriestley updated the task description. (Show Details)Apr 17 2020, 5:00 PM

epriestley added a commit: rP3d966d8a41f1: Add an "Open in External Editor" keystroke to Differential.Apr 17 2020, 5:06 PM

epriestley added a revision: D21136: When inlines would disable a file shield in a diff, still apply the shield if all the comments are collapsed.Apr 17 2020, 5:32 PM

epriestley updated the task description. (Show Details)Apr 17 2020, 5:49 PM

epriestley added a commit: rP3adf082002aa: When inlines would disable a file shield in a diff, still apply the shield if….Apr 17 2020, 5:52 PM

epriestley updated the task description. (Show Details)Apr 17 2020, 8:54 PM

epriestley added a revision: D21140: Move "External Editor" settings to a separate settings group.Apr 18 2020, 4:56 PM

epriestley added a revision: D21141: Make the "Keyboard Shortcuts" dialog in Differential less hideous.Apr 18 2020, 6:25 PM

epriestley added a revision: D21142: Remove the "Edit Multiple Files" external editor setting.Apr 18 2020, 6:34 PM

epriestley added a revision: D21143: Tokenize external editor links so they can be safely materialized on the client.Apr 18 2020, 9:31 PM

epriestley added a revision: D21144: Replace old hard-coded URI-based "changes saved" jank with new overgeneralized cookie-based "changes saved" jank.Apr 18 2020, 10:24 PM