Actually, I think this is a separate bug, moving to MenuItem, it's still broken there as well. Probably related to T11114

I think the item didn't exist at all before, and T11114 created it as a side effect. All the installs I have immediate access to are up to date, but, e.g., neither the KDE nor WMF installs have "Create Diff" or "Create Revision" in the menu even though I have access to Differential on both.

(It may have existed in very old versions of Phabricator, before we changed the Quick Create menu to be driven by EditEngine.)

T5867 will probably "fix" this in the near term by removing the item from the default list, although users who add a new "EditEngine" item pointing at this engine will get the same behavior. Some other engines probably have similar behavior (for example, if you point at link at CommitEditEngine, there's nothing reasonable it can possibly do: there's no flow for creating a commit from the web UI).

My planned path forward here is:

• Wait for T5867 to shove this under a rug.
• Eventually, tailor the behavior by giving EditEngine some methods to customize how its MenuItems work, so the one for RevisionEditEngine can be called "Create Diff" and point at the diff creation form? I guess? Or just removing these as options? You can always use a link item, instead.

...and maaaybe throw a hacky patch on this before we promote stable if T5867 doesn't make it to master by then.