Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13188888
D9877.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
4 KB
Referenced Files
None
Subscribers
None
D9877.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -944,6 +944,7 @@
'ManiphestTaskMailReceiver' => 'applications/maniphest/mail/ManiphestTaskMailReceiver.php',
'ManiphestTaskOwner' => 'applications/maniphest/constants/ManiphestTaskOwner.php',
'ManiphestTaskPriority' => 'applications/maniphest/constants/ManiphestTaskPriority.php',
+ 'ManiphestTaskPriorityDatasource' => 'applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php',
'ManiphestTaskProject' => 'applications/maniphest/storage/ManiphestTaskProject.php',
'ManiphestTaskQuery' => 'applications/maniphest/query/ManiphestTaskQuery.php',
'ManiphestTaskResultListView' => 'applications/maniphest/view/ManiphestTaskResultListView.php',
@@ -3724,6 +3725,7 @@
'ManiphestTaskMailReceiver' => 'PhabricatorObjectMailReceiver',
'ManiphestTaskOwner' => 'ManiphestConstants',
'ManiphestTaskPriority' => 'ManiphestConstants',
+ 'ManiphestTaskPriorityDatasource' => 'PhabricatorTypeaheadDatasource',
'ManiphestTaskProject' => 'ManiphestDAO',
'ManiphestTaskQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
'ManiphestTaskResultListView' => 'ManiphestView',
diff --git a/src/applications/herald/controller/HeraldRuleController.php b/src/applications/herald/controller/HeraldRuleController.php
--- a/src/applications/herald/controller/HeraldRuleController.php
+++ b/src/applications/herald/controller/HeraldRuleController.php
@@ -591,6 +591,7 @@
$sources = array(
'repository' => new DiffusionRepositoryDatasource(),
'legaldocuments' => new LegalpadDocumentDatasource(),
+ 'taskpriority' => new ManiphestTaskPriorityDatasource(),
);
$sources = mpull($sources, 'getDatasourceURI');
@@ -601,7 +602,6 @@
'project' => '/typeahead/common/projects/',
'userorproject' => '/typeahead/common/accountsorprojects/',
'buildplan' => '/typeahead/common/buildplans/',
- 'taskpriority' => '/typeahead/common/taskpriority/',
'arcanistprojects' => '/typeahead/common/arcanistprojects/',
);
diff --git a/src/applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php b/src/applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php
new file mode 100644
--- /dev/null
+++ b/src/applications/maniphest/typeahead/ManiphestTaskPriorityDatasource.php
@@ -0,0 +1,31 @@
+<?php
+
+final class ManiphestTaskPriorityDatasource
+ extends PhabricatorTypeaheadDatasource {
+
+ public function getPlaceholderText() {
+ return pht('Type a task priority name...');
+ }
+
+ public function getDatasourceApplicationClass() {
+ return 'PhabricatorApplicationManiphest';
+ }
+
+ public function loadResults() {
+ $viewer = $this->getViewer();
+ $raw_query = $this->getRawQuery();
+
+ $results = array();
+
+ $priority_map = ManiphestTaskPriority::getTaskPriorityMap();
+ foreach ($priority_map as $value => $name) {
+ // NOTE: $value is not a phid but is unique. This'll work.
+ $results[] = id(new PhabricatorTypeaheadResult())
+ ->setPHID($value)
+ ->setName($name);
+ }
+
+ return $results;
+ }
+
+}
diff --git a/src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php b/src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php
--- a/src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php
+++ b/src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php
@@ -33,7 +33,6 @@
$need_symbols = false;
$need_jump_objects = false;
$need_build_plans = false;
- $need_task_priority = false;
switch ($this->type) {
case 'mainsearch':
$need_users = true;
@@ -84,9 +83,6 @@
case 'buildplans':
$need_build_plans = true;
break;
- case 'taskpriority':
- $need_task_priority = true;
- break;
}
$results = array();
@@ -225,16 +221,6 @@
}
}
- if ($need_task_priority) {
- $priority_map = ManiphestTaskPriority::getTaskPriorityMap();
- foreach ($priority_map as $value => $name) {
- // NOTE: $value is not a phid but is unique. This'll work.
- $results[] = id(new PhabricatorTypeaheadResult())
- ->setPHID($value)
- ->setName($name);
- }
- }
-
if ($need_projs) {
$projs = id(new PhabricatorProjectQuery())
->setViewer($viewer)
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, May 12, 5:34 AM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6285027
Default Alt Text
D9877.diff (4 KB)
Attached To
Mode
D9877: Modernize "task priority" datasource
Attached
Detach File
Event Timeline
Log In to Comment