Page MenuHomePhabricator
Files F13183238

D21812.diff
No OneTemporary
Actions

D21812.diff
View Options

diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
@@ -78,12 +78,6 @@
$comment->setViewPolicy(PhabricatorPolicies::POLICY_PUBLIC);
$comment->setEditPolicy($this->getActingAsPHID());
- $file_phids = PhabricatorMarkupEngine::extractFilePHIDsFromEmbeddedFiles(
- $actor,
- array(
- $comment->getContent(),
- ));
-
$xaction->openTransaction();
$xaction->beginReadLocking();
if ($xaction->getID()) {
@@ -132,18 +126,6 @@
$xaction->endReadLocking();
$xaction->saveTransaction();
- // Add links to any files newly referenced by the edit.
- if ($file_phids) {
- $editor = new PhabricatorEdgeEditor();
- foreach ($file_phids as $file_phid) {
- $editor->addEdge(
- $xaction->getObjectPHID(),
- PhabricatorObjectHasFileEdgeType::EDGECONST ,
- $file_phid);
- }
- $editor->save();
- }
-
return $this;
}
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -4042,15 +4042,7 @@
PhabricatorLiskDAO $object,
array $xactions) {
- $changes = $this->getRemarkupChanges($xactions);
- $blocks = mpull($changes, 'getNewValue');
-
$phids = array();
- if ($blocks) {
- $phids[] = PhabricatorMarkupEngine::extractFilePHIDsFromEmbeddedFiles(
- $this->getActor(),
- $blocks);
- }
foreach ($xactions as $xaction) {
$type = $xaction->getTransactionType();

File Metadata

Mime Type
text/plain
Expires
May 11 2024, 7:43 AM (4 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6285133
Default Alt Text
D21812.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility