Page MenuHomePhabricator
Differential D9888

Modernize "user, project or package" typeahead datasource
ClosedPublic
Actions

Authored by epriestley on Jul 11 2014, 3:04 AM.
Tags
None
Referenced Files
F13301186: D9888.id.diff
Fri, Jun 7, 4:18 PM
F13301014: D9888.id.diff
Fri, Jun 7, 2:38 PM
F13297432: D9888.id23939.diff
Fri, Jun 7, 5:19 AM
F13280920: D9888.diff
Sun, Jun 2, 9:28 AM
F13271669: D9888.diff
Thu, May 30, 3:47 AM
F13268614: D9888.diff
Wed, May 29, 5:13 AM
F13253074: D9888.diff
Sat, May 25, 2:22 AM
F13230924: D9888.diff
Mon, May 20, 11:25 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rPcab442fe8ce8: Modernize "user, project or package" typeahead datasource
Summary

Ref T4420. Call this "auditor" since that's what it is.

Test Plan
  • Edited auditors in auditor search.
  • Edited auditors in "add auditors" in Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
tok4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1632
Build 1633: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23744.Jul 11 2014, 3:04 AM
epriestley retitled this revision from to Modernize "user, project or package" typeahead datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4420: Modernize typeahead datasources.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 11 2014, 3:04 AM
Harbormaster completed remote builds in B1632: Diff 23744.Jul 11 2014, 3:06 AM
btrahan accepted this revision.Jul 17 2014, 10:28 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 10:28 PM
epriestley closed this revision.Jul 17 2014, 10:45 PM
epriestley updated this revision to Diff 23939.

Closed by commit rPcab442fe8ce8 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
audit/
query/
2 lines
diffusion/
controller/
5 lines
typeahead/
22 lines
typeahead/
controller/
18 lines
view/
form/
control/
2 lines

Diff 23744

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/typeahead/DiffusionAuditorDatasource.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
View Options

src/view/form/control/AphrontFormTokenizerControl.php

Loading...
Phabricator · Built by Phacility