Differential D9875

Modernize "macro" typeahead datasource
ClosedPublic
Actions

Authored by epriestley on Jul 10 2014, 8:43 PM.

Tags

None

Referenced Files

	F13183117: D9875.id23714.diff
	Fri, May 10, 6:58 AM

	F13183116: D9875.id23726.diff
	Fri, May 10, 6:58 AM

	F13183115: D9875.id23713.diff
	Fri, May 10, 6:58 AM

	F13177546: D9875.diff
	Wed, May 8, 7:47 PM

	Unknown Object (File)
	Mon, Apr 29, 3:52 PM

	Unknown Object (File)
	Wed, Apr 24, 10:28 PM

	Unknown Object (File)
	Sat, Apr 20, 7:17 PM

	Unknown Object (File)
	Apr 4 2024, 4:18 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4420: Modernize typeahead datasources

Commits

Restricted Diffusion Commit
rPa2caea13d65f: Modernize "macro" typeahead datasource

Summary

Ref T4420. Make this modern.

Test Plan

Used typeahead in remarkup comment area to select macro "derpdog".

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23713.Jul 10 2014, 8:43 PM

epriestley retitled this revision from to Modernize "macro" typeahead datasource.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4420: Modernize typeahead datasources.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 10 2014, 8:43 PM

Forgot to save file removing this from common typehead.

Harbormaster completed remote builds in B1612: Diff 23713.Jul 10 2014, 8:44 PM

Harbormaster completed remote builds in B1613: Diff 23714.

I think I'm learning about the nitty gritty of how this icon stuff works over these diffs.

src/applications/macro/typeahead/PhabricatorMacroDatasource.php
30	oh, I guess if you want the color you have to specify it here too?

This revision is now accepted and ready to land.Jul 10 2014, 10:34 PM

The icon stuff is dumb right now, my end-of-this-sequence plan is to make Results go look up the PHIDType and use the icon/color on that, if one isn't provided. That will delete 90% of the code and just leave a couple of special cases (mostly projects). For now, I'm just moving the code into modular datasources without touching it too much.

Closed by commit rPa2caea13d65f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

macro/

controller/

PhabricatorMacroMemeDialogController.php

2 lines

phid/

PhabricatorMacroPHIDTypeMacro.php

4 lines

typeahead/

PhabricatorMacroDatasource.php

35 lines

repository/

phid/

PhabricatorRepositoryPHIDTypeRepository.php

5 lines

typeahead/

controller/

PhabricatorTypeaheadCommonDatasourceController.php

17 lines

Diff 23726

src/__phutil_library_map__.php

Loading...

src/applications/macro/controller/PhabricatorMacroMemeDialogController.php

Loading...

src/applications/macro/phid/PhabricatorMacroPHIDTypeMacro.php

Loading...

src/applications/macro/typeahead/PhabricatorMacroDatasource.php

Loading...

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeRepository.php

Loading...

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...