Page MenuHomePhabricator

Modernize "repositories" typeahead datasource
ClosedPublic

Authored by epriestley on Jul 10 2014, 8:35 PM.
Tags
None
Referenced Files
F13296958: D9874.diff
Thu, Jun 6, 10:45 PM
F13272264: D9874.diff
Thu, May 30, 11:35 AM
F13266511: D9874.id23711.diff
Tue, May 28, 2:43 PM
F13261614: D9874.diff
Mon, May 27, 1:15 AM
F13251334: D9874.id23725.diff
Fri, May 24, 10:25 PM
F13247711: D9874.id23710.diff
Thu, May 23, 9:52 PM
F13238362: D9874.id23725.diff
Tue, May 21, 6:59 PM
F13228529: D9874.id23725.diff
Mon, May 20, 10:11 AM
Subscribers

Details

Summary

Ref T4420.

  • Allow tokenizers to accept either a Datasource object (new style) or a URI (old style).
  • Read URI and placeholder text from object, if available.
  • Swap the "repositories" datasource (which seemed like the simplest one) over to the new stuff.
  • Tweak/update the repo tokens a little bit.
Test Plan
  • Used tokenizer in Herald, Differential (search), Differential (edit), Push Logs.
  • Grepped for other callsites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Modernize "repositories" typeahead datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Also remove it from the old datasource.
  • Implement getDatasourceApplicationClass() properly.
btrahan edited edge metadata.

I dig the new pattern.

This revision is now accepted and ready to land.Jul 10 2014, 10:30 PM
epriestley updated this revision to Diff 23725.

Closed by commit rP34628002fd96 (authored by @epriestley).