Page MenuHomePhabricator
Differential D9851

Stop reads and writes to projectPHIDs property on ManiphestTask
ClosedPublic
Actions

Authored by epriestley on Jul 6 2014, 3:28 PM.
Tags
None
Referenced Files
F13241612: D9851.id23933.diff
Wed, May 22, 10:47 PM
F13206427: D9851.id23644.diff
Wed, May 15, 9:52 AM
F13200611: D9851.id23933.diff
Tue, May 14, 1:54 AM
F13199712: D9851.id.diff
Mon, May 13, 5:24 PM
F13190158: D9851.id23622.diff
Sat, May 11, 7:57 AM
Unknown Object (File)
Tue, May 7, 5:36 AM
Unknown Object (File)
Tue, May 7, 5:31 AM
Unknown Object (File)
Tue, May 7, 5:31 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
chad
Maniphest Tasks
T5245: Migrate Maniphest Projects to use edge infrastructure
Commits
Restricted Diffusion Commit
rPb8b59895eeec: Stop reads and writes to projectPHIDs property on ManiphestTask
Summary

Ref T5245. This property predates edges and is unusual in modern applications. Stop writes to it and populate it implicitly from edges when querying.

Test Plan
  • Viewed task list.
  • Created a task.
  • Added and removed projects from tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23622.Jul 6 2014, 3:28 PM
epriestley retitled this revision from to Stop reads and writes to projectPHIDs property on ManiphestTask.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad, btrahan.
epriestley added a task: T5245: Migrate Maniphest Projects to use edge infrastructure.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 6 2014, 3:28 PM
Harbormaster completed remote builds in B1554: Diff 23622.Jul 6 2014, 3:29 PM
joshuaspence added a parent revision: D9850: Move task/project storage to edges.Jul 6 2014, 10:21 PM
epriestley updated this revision to Diff 23642.Jul 7 2014, 5:18 PM
  • Rebasing on changes further down in the stack.
Harbormaster completed remote builds in B1574: Diff 23642.Jul 7 2014, 5:19 PM
epriestley updated this revision to Diff 23644.Jul 7 2014, 5:22 PM
  • Modern edgetype classes.
Harbormaster completed remote builds in B1576: Diff 23644.Jul 7 2014, 5:23 PM
btrahan accepted this revision.Jul 10 2014, 5:07 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 10 2014, 5:07 PM
epriestley closed this revision.Jul 17 2014, 10:42 PM
epriestley updated this revision to Diff 23933.

Closed by commit rPb8b59895eeec (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
6 lines
editor/
5 lines
query/
21 lines
storage/
14 lines
7 lines

Diff 23933

View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTaskProject.php

Loading...
Phabricator · Built by Phacility