Differential D9670

Allow administrators to set a dashboard as a global default
ClosedPublic
Actions

Authored by epriestley on Jun 22 2014, 7:35 PM.

Tags

None

Referenced Files

	F13231216: D9670.diff
	Tue, May 21, 12:17 AM

	F13223951: D9670.id23281.diff
	Sun, May 19, 5:32 AM

	F13209627: D9670.diff
	Fri, May 17, 1:14 AM

	Unknown Object (File)
	Tue, May 7, 3:46 AM

	Unknown Object (File)
	May 1 2024, 12:24 AM

	Unknown Object (File)
	Apr 29 2024, 8:04 PM

	Unknown Object (File)
	Apr 29 2024, 2:50 PM

	Unknown Object (File)
	Apr 28 2024, 10:28 PM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4883: Customizing the default homepage for all users

Commits

Restricted Diffusion Commit
rPabcd3efa5a2f: Allow administrators to set a dashboard as a global default

Summary

Ref T4883.

When an administrator installs a dashbord, give them the option to install it as a global default.
On the home page, if a user does not have a dashboard installed, check for a global default.
On the Admin NUX/Welcome page, check for a global dashboard.

Test Plan

Installed a global dashboard, checked homepage, saw it.
Installed a personal dashboard over it.
Checked non-admin flow.
Checked Admin NUX page for quest completion.

Diff Detail

Repository

Branch

dash4

Lint

Lint Errors

Severity	Location	Code	Message
Error	/INSECURE/devtools/arcanist/src/lint/engine/ComprehensiveLintEngine.php:42	PHL1	Unknown Symbol

Unit

No Test Coverage

Build Status

Buildable 1307
Build 1307: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23211.Jun 22 2014, 7:35 PM

epriestley retitled this revision from to Allow administrators to set a dashboard as a global default.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T4883: Customizing the default homepage for all users.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 22 2014, 7:35 PM

Harbormaster completed remote builds in B1307: Diff 23211.Jun 22 2014, 7:36 PM

chad accepted this revision.Jun 23 2014, 8:39 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2014, 8:39 PM

Closed by commit rPabcd3efa5a2f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

controller/

PhabricatorConfigWelcomeController.php

5 lines

dashboard/

controller/

PhabricatorDashboardInstallController.php

120 lines

home/

application/

PhabricatorApplicationHome.php

2 lines

controller/

PhabricatorHomeMainController.php

8 lines

Diff 23211

src/applications/config/controller/PhabricatorConfigWelcomeController.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardInstallController.php

Loading...

src/applications/home/application/PhabricatorApplicationHome.php

Loading...

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...