Page MenuHomePhabricator
Differential D21842

Migrate "SlowvotePoll" to modern mailkey storage
ClosedPublic
Actions

Authored by epriestley on May 26 2022, 12:10 AM.
Tags
None
Referenced Files
F13270448: D21842.id52059.diff
Wed, May 29, 9:43 AM
F13270447: D21842.id52057.diff
Wed, May 29, 9:43 AM
F13270445: D21842.id.diff
Wed, May 29, 9:42 AM
F13201097: D21842.diff
May 14 2024, 7:59 AM
F13198331: D21842.diff
May 13 2024, 5:48 AM
F13191607: D21842.diff
May 11 2024, 10:47 PM
F13183029: D21842.diff
May 10 2024, 6:18 AM
Unknown Object (File)
May 6 2024, 1:16 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13065: Move storage for `mailKey` to the Mail application
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rPb1533e5468b1: Migrate "SlowvotePoll" to modern mailkey storage
Summary

Ref T13682. Ref T13065. Migrate and update "SlowvotePoll" to use more modern mailkey storage (in the mail application, rather than onboard).

Also make other minor modernization changes.

Test Plan

Created a new poll. Ran migration, verified mail key copied properly in database.

Diff Detail

Repository
rP Phabricator
Branch
svote2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25749
Build 35577: arc lint + arc unit

Event Timeline

epriestley created this revision.May 26 2022, 12:10 AM
Owners added a subscriber: Restricted Owners Package.May 26 2022, 12:10 AM
epriestley requested review of this revision.May 26 2022, 12:10 AM
Harbormaster completed remote builds in B25749: Diff 52057.May 26 2022, 12:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2022, 4:29 PM
Closed by commit rPb1533e5468b1: Migrate "SlowvotePoll" to modern mailkey storage (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPb1533e5468b1: Migrate "SlowvotePoll" to modern mailkey storage.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
28 lines
2 lines
src/
applications/
slowvote/
storage/
17 lines

Diff 52057

View Options

resources/sql/autopatches/20220525.slowvote.01.mailkey.php

Loading...
View Options

resources/sql/autopatches/20220525.slowvote.02.mailkey-drop.sql

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
Phabricator · Built by Phacility