Page MenuHomePhabricator
Differential D21836

Provide a rudimentary "Attached Files" curtain UI panel
ClosedPublic
Actions

Authored by epriestley on May 23 2022, 6:13 PM.
Tags
None
Referenced Files
F13274902: D21836.diff
Fri, May 31, 4:11 AM
F13270417: D21836.id52045.diff
Wed, May 29, 9:39 AM
F13270416: D21836.id52041.diff
Wed, May 29, 9:39 AM
F13270415: D21836.id.diff
Wed, May 29, 9:39 AM
F13266807: D21836.diff
Tue, May 28, 8:03 PM
F13260952: D21836.diff
Mon, May 27, 12:35 AM
F13243421: D21836.diff
Thu, May 23, 3:55 AM
F13223187: D21836.diff
Sun, May 19, 4:22 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP021e5ab933e4: Provide a rudimentary "Attached Files" curtain UI panel
Summary

Ref T13682. Provide a basic UI element for showing file attached to an object.

Test Plan

Viewed objects with attached files in the UI.

Diff Detail

Repository
rP Phabricator
Branch
file5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25741
Build 35569: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 23 2022, 6:13 PM
epriestley created this revision.
Harbormaster completed remote builds in B25741: Diff 52041.May 23 2022, 6:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
Closed by commit rP021e5ab933e4: Provide a rudimentary "Attached Files" curtain UI panel (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP021e5ab933e4: Provide a rudimentary "Attached Files" curtain UI panel.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
application/
2 lines
controller/
61 lines
engineextension/
89 lines

Diff 52041

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileUICurtainListController.php

Loading...
View Options

src/applications/files/engineextension/PhabricatorFilesCurtainExtension.php

Loading...
Phabricator · Built by Phacility