Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl"
ClosedPublic
Actions

Authored by epriestley on May 20 2022, 5:12 PM.

Tags

None

Referenced Files

	F13276240: D21831.diff
	Fri, May 31, 5:43 AM

	F13270397: D21831.id52032.diff
	Wed, May 29, 9:37 AM

	F13270396: D21831.id52031.diff
	Wed, May 29, 9:37 AM

	F13270395: D21831.id.diff
	Wed, May 29, 9:37 AM

	F13239314: D21831.id.diff
	Wed, May 22, 1:51 AM

	F13227762: D21831.diff
	Mon, May 20, 5:05 AM

	F13207194: D21831.diff
	Wed, May 15, 9:58 PM

	F13206521: D21831.diff
	Wed, May 15, 11:25 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl"

Summary

Ref T13682. This method originated in D4781 and no longer has any callers; remove it.

(I believe this was from an era where macros didn't have to be on their own line to trigger.)

Test Plan

Grepped for method, found no callers.

Diff Detail

Repository

rP Phabricator

Branch

file1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25733
Build 35561: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 20 2022, 5:12 PM

epriestley created this revision.

Harbormaster completed remote builds in B25733: Diff 52031.May 20 2022, 5:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2022, 5:27 PM

Closed by commit rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".

Revision Contents
Changeset List

Path

Size

src/

view/

form/

control/

PhabricatorRemarkupControl.php

10 lines

Diff 52031

View Options

src/view/form/control/PhabricatorRemarkupControl.php

Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl"ClosedPublicActions