Page MenuHomePhabricator

Add database storage for a dedicated file attachment table
ClosedPublic

Authored by epriestley on May 10 2022, 11:24 PM.
Tags
None
Referenced Files
F13319755: D21813.diff
Thu, Jun 13, 2:13 PM
F13309846: D21813.id52022.diff
Mon, Jun 10, 10:40 AM
F13305932: D21813.id52022.diff
Sun, Jun 9, 4:45 AM
F13305009: D21813.diff
Sat, Jun 8, 3:58 PM
F13288074: D21813.diff
Tue, Jun 4, 9:46 AM
F13285861: D21813.diff
Tue, Jun 4, 3:51 AM
F13276022: D21813.diff
Fri, May 31, 5:27 AM
F13270331: D21813.id52022.diff
Wed, May 29, 9:31 AM
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rPcfa42c5e655c: Add database storage for a dedicated file attachment table
Summary

Ref T13603. Prepare to move this relationship out of edge storage into dedicated storage so it is easier to formalize better in the UI.

Test Plan

Ran bin/storage upgrade.

Diff Detail

Repository
rP Phabricator
Branch
file2
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25710
Build 35538: arc lint + arc unit

Unit TestsFailed

TimeTest
63 msPhabricatorFileTestCase::testFileIndirectScramble
Assertion failed, expected 'true' (at PhabricatorFileTestCase.php:135): Changing attached object view policy should scramble secret. ACTUAL VALUE
227 msPhabricatorCelerityTestCase::testCelerityMaps
3 assertions passed.
9 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
19 msPhabricatorFileTestCase::testFileDirectScramble
2 assertions passed.
7 msPhabricatorFileTestCase::testFileStorageDelete
1 assertion passed.
View Full Test Results (1 Failed · 16 Passed)

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 10 2022, 11:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.