Page MenuHomePhabricator
Differential D21786

Remove product literal strings in "pht()", part 20
ClosedPublic
Actions

Authored by epriestley on Apr 25 2022, 11:12 PM.
Tags
None
Referenced Files
F13318408: D21786.diff
Thu, Jun 13, 11:02 AM
F13314093: D21786.id.diff
Tue, Jun 11, 4:43 PM
F13303139: D21786.diff
Sat, Jun 8, 6:21 AM
F13297004: D21786.id.diff
Thu, Jun 6, 11:26 PM
F13296653: D21786.id51923.diff
Thu, Jun 6, 5:58 PM
F13284540: D21786.id51924.diff
Mon, Jun 3, 6:21 AM
F13272818: D21786.id51924.diff
Thu, May 30, 10:06 PM
F13270237: D21786.id51941.diff
Wed, May 29, 9:24 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13658: How to rebrand Phabricator
Commits
rP07723b46274c: Remove product literal strings in "pht()", part 20
Summary

Ref T13658.

Test Plan

Static checks only.

Diff Detail

Repository
rP Phabricator
Branch
product21
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/herald/controller/HeraldWebhookViewController.php:56XHP134Use of Product Name Literal
Unit
Tests Passed
Build Status
Buildable 25680
Build 35508: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Apr 25 2022, 11:12 PM
epriestley created this revision.
Harbormaster completed remote builds in B25679: Diff 51923.Apr 25 2022, 11:12 PM
epriestley updated this revision to Diff 51924.Apr 25 2022, 11:13 PM
  • Fix a PHP 8.1 "strlen(null)" issue.
Harbormaster completed remote builds in B25680: Diff 51924.Apr 25 2022, 11:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 11:47 PM
This revision was landed with ongoing or failed builds.
Closed by commit rP07723b46274c: Remove product literal strings in "pht()", part 20 (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP07723b46274c: Remove product literal strings in "pht()", part 20.

Revision Contents
Changeset List

Diff 51924

View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/controller/HeraldWebhookViewController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Loading...
View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

Loading...
View Options

src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php

Loading...
View Options

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php

Loading...
View Options

src/applications/metamta/query/PhabricatorMetaMTAActor.php

Loading...
View Options

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

Loading...
Phabricator · Built by Phacility