Differential D21757

Improve some PHP 8.1 behavior in "bin/auth recover"
ClosedPublic
Actions

Authored by epriestley on Apr 19 2022, 9:48 PM.

Tags

None

Referenced Files

	F13274367: D21757.diff
	Fri, May 31, 3:37 AM

	F13270176: D21757.diff
	Wed, May 29, 9:15 AM

	F13260410: D21757.diff
	Sun, May 26, 11:52 PM

	F13247778: D21757.id51866.diff
	Thu, May 23, 10:25 PM

	F13244610: D21757.diff
	Thu, May 23, 5:11 AM

	F13196230: D21757.diff
	Sun, May 12, 11:05 PM

	F13181630: D21757.id51867.diff
	Thu, May 9, 1:54 PM

	Unknown Object (File)
	Fri, May 3, 3:29 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rP21b1a304b60a: Improve some PHP 8.1 behavior in "bin/auth recover"

Summary

Ref T13588. Fix a couple of argument parsing issues here.

Test Plan

Ran "bin/auth recover" under PHP 8.1.

Diff Detail

Repository

Branch

php1

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25641
Build 35469: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	14 ms	PhabricatorAuthSSHKeyTestCase::testRevokeSSHKey EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(2923): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 2923) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php(112): PhabricatorApplicationTransactionEditor->validateIsEmptyTextField(NULL, Array)
	383 ms	PhabricatorAuthPasswordTestCase::testCompare 2 assertions passed.
	35 ms	PhabricatorAuthPasswordTestCase::testPasswordBlocklisting 15 assertions passed.
	1,634 ms	PhabricatorAuthPasswordTestCase::testPasswordEngine 20 assertions passed.
	320 ms	PhabricatorAuthPasswordTestCase::testPasswordUpgrade 9 assertions passed.
		View Full Test Results (1 Failed · 11 Passed)

Event Timeline

epriestley requested review of this revision.Apr 19 2022, 9:48 PM

epriestley created this revision.

Harbormaster completed remote builds in B25641: Diff 51866.Apr 19 2022, 9:48 PM

Also fix some unit test behaviors.

Harbormaster completed remote builds in B25642: Diff 51867.Apr 19 2022, 9:54 PM

epriestley mentioned this in D21758: Fix a PHP 8.1 issue with "phutil_console_strlen()".Apr 19 2022, 9:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2022, 9:55 PM

Closed by commit rP21b1a304b60a: Improve some PHP 8.1 behavior in "bin/auth recover" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rARC1fc4439ca5ff: Fix a PHP 8.1 issue with "phutil_console_strlen()".

epriestley added a commit: rP21b1a304b60a: Improve some PHP 8.1 behavior in "bin/auth recover".

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

management/

PhabricatorAuthManagementRevokeWorkflow.php

4 lines

Diff 51866

src/applications/auth/management/PhabricatorAuthManagementRevokeWorkflow.php

Loading...