Page MenuHomePhabricator

Fix two minor display issues with the Conduit "*.search" API documentation
ClosedPublic

Authored by epriestley on Jul 31 2019, 6:22 PM.
Tags
None
Referenced Files
F13265021: D20686.id49336.diff
Tue, May 28, 12:43 AM
F13246608: D20686.id49339.diff
Thu, May 23, 11:57 AM
F13225956: D20686.diff
Sun, May 19, 6:29 PM
F13215967: D20686.id.diff
Fri, May 17, 9:27 PM
Unknown Object (File)
Apr 28 2024, 6:08 AM
Unknown Object (File)
Apr 24 2024, 10:47 PM
Unknown Object (File)
Apr 20 2024, 4:52 PM
Unknown Object (File)
Apr 18 2024, 11:21 PM
Subscribers
None

Details

Summary

Depends on D20685. Ref T13350. Currently:

  • When a SearchEngine parameter is marked as hidden from Conduit, we may still render a table of possible values. Instead, only render the table if the parameter is actually usable.
  • The table header is hard-coded to say 'statuses', which is just a silly mistake. (Most commonly, this table does have statuses constants.)
Test Plan

Viewed the Conduit API documentation for the new "slowvote.poll.search" API method, saw more sensible display behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable