Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
F13257582: D20671.diff
Sun, May 26, 2:48 AM
F13254672: D20671.diff
Sat, May 25, 3:36 AM
F13233972: D20671.diff
Tue, May 21, 2:41 AM
F13225900: D20671.diff
Sun, May 19, 6:08 PM
F13209074: D20671.diff
Thu, May 16, 9:35 PM
F13198445: D20671.id49298.diff
Mon, May 13, 6:35 AM
F13188986: D20671.diff
Sat, May 11, 5:39 AM
F13188108: D20671.id.diff
Sat, May 11, 5:02 AM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable