Page MenuHomePhabricator

Call `$linter->setEngine` in linter tests
ClosedPublic

Authored by joshuaspence on May 13 2019, 4:27 AM.
Tags
None
Referenced Files
F13281678: D20515.diff
Sun, Jun 2, 11:05 AM
F13243083: D20515.diff
Thu, May 23, 3:19 AM
F13236851: D20515.diff
Tue, May 21, 11:12 AM
F13227507: D20515.id48908.diff
Mon, May 20, 3:51 AM
F13221626: D20515.diff
Sun, May 19, 2:55 AM
F13204387: D20515.diff
Wed, May 15, 12:32 AM
F13186636: D20515.diff
Sat, May 11, 3:46 AM
F13184615: D20515.diff
Fri, May 10, 9:11 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

We aren't calling $linter->setEngine($engine), even though we do have an $engine. This causes unit tests for any linters which require an engine to fail.

Test Plan

Ran the unit tests for a third-party linter.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22781
Build 31249: Run Core Tests
Build 31248: arc lint + arc unit