Page MenuHomePhabricator
Differential D20414

Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages
ClosedPublic
Actions

Authored by epriestley on Apr 12 2019, 11:48 PM.
Tags
None
Referenced Files
F13220976: D20414.diff
Sun, May 19, 2:10 AM
F13184871: D20414.id48708.diff
Sat, May 11, 1:08 AM
F13183309: D20414.id48757.diff
Fri, May 10, 8:15 AM
Unknown Object (File)
Tue, May 7, 5:29 AM
Unknown Object (File)
Fri, May 3, 3:05 AM
Unknown Object (File)
Wed, May 1, 8:51 PM
Unknown Object (File)
Mon, Apr 29, 2:36 PM
Unknown Object (File)
Mon, Apr 29, 2:36 PM
View All 67 Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13272: Remove the hard-coded homepage, and other Dashboards improvements
Commits
rPe99c1974b027: Fix the "Add Query to Dashboard..." flow from "Use Results" on search result…
Summary

Depends on D20413. Ref T13272. When you search for stuff, you can "Use Results > Add to Dashboard" to generate a query panel.

This needs some updating after the recent refactoring. All the changes are pretty straightforward. Swaps a giant <select /> for a tokenizer with a datasource.

Test Plan

Used the "Use Results > Add to Dashboard" flow to create a panel on a dashboard using a query.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 48757

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

Loading...
View Options

src/applications/dashboard/layoutconfig/PhabricatorDashboardPanelRefList.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...
View Options

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php

Loading...
Phabricator · Built by Phacility