Page MenuHomePhabricator
Differential D20286

Modularize workboard column transactions
ClosedPublic
Actions

Authored by epriestley on Mar 14 2019, 3:22 PM.
Tags
None
Referenced Files
F13265959: D20286.diff
Tue, May 28, 7:27 AM
F13264894: D20286.id.diff
Mon, May 27, 11:07 PM
F13255092: D20286.diff
Sat, May 25, 4:24 AM
F13240536: D20286.id48425.diff
Wed, May 22, 2:55 PM
F13233719: D20286.diff
Tue, May 21, 2:31 AM
F13217732: D20286.diff
Sat, May 18, 7:45 AM
F13211913: D20286.diff
Fri, May 17, 6:13 AM
F13209565: D20286.id48489.diff
Fri, May 17, 12:57 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T5474: Support workboard column triggers which activate when a task is dropped into a column
Commits
rP0204489a5265: Modularize workboard column transactions
Summary

Depends on D20279. Ref T5474. Modernize these transactions before I add a new "TriggerTransaction" for setting triggers.

Test Plan

Created a column. Edited a column name and point limit. Hid and un-hid a column. Grepped for removed symbols.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 14 2019, 3:22 PM
Harbormaster completed remote builds in B22288: Diff 48425.Mar 14 2019, 3:24 PM
epriestley requested review of this revision.Mar 14 2019, 3:24 PM
epriestley added inline comments.Mar 14 2019, 3:25 PM
src/applications/project/controller/PhabricatorProjectColumnEditController.php
96

This fixes a bug where this workflow didn't actually enforce the requirement that columns have a name.

epriestley added a child revision: D20287: Allow triggers to be attached to and removed from workboard columns.Mar 14 2019, 5:23 PM
amckinley accepted this revision.Mar 18 2019, 6:57 PM
amckinley added inline comments.
src/applications/project/xaction/column/PhabricatorProjectColumnLimitTransaction.php
40

For consistency, "changed the point limit".

src/applications/project/xaction/column/PhabricatorProjectColumnStatusTransaction.php
23

"unhid this column"

27

"hid this column"

48

This is just going to be "0, 1"; maybe don't even bother to show it?

This revision is now accepted and ready to land.Mar 18 2019, 6:57 PM
epriestley added inline comments.Mar 25 2019, 6:48 PM
src/applications/project/xaction/column/PhabricatorProjectColumnStatusTransaction.php
48

I think it'll be real strings some day. Showing it is mostly for the benefit of API callers, since the internal constants may not always be obvious.

epriestley updated this revision to Diff 48489.Mar 25 2019, 6:49 PM
  • Wordsmithing.
Harbormaster completed remote builds in B22361: Diff 48489.Mar 25 2019, 6:51 PM
Closed by commit rP0204489a5265: Modularize workboard column transactions (authored by epriestley). · Explain WhyMar 25 2019, 8:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48494

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnEditController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnHideController.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectColumnTransactionEditor.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectColumnTransaction.php

Loading...
View Options

src/applications/project/xaction/column/PhabricatorProjectColumnLimitTransaction.php

Loading...
View Options

src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php

Loading...
View Options

src/applications/project/xaction/column/PhabricatorProjectColumnStatusTransaction.php

Loading...
View Options

src/applications/project/xaction/column/PhabricatorProjectColumnTransactionType.php

Loading...
Phabricator · Built by Phacility