Differential D20043

Allow MFA enrollment guidance to be customized
ClosedPublic
Actions

Authored by epriestley on Jan 28 2019, 5:28 PM.

Tags

None

Referenced Files

	F13275465: D20043.diff
	Fri, May 31, 4:48 AM

	F13261636: D20043.diff
	Mon, May 27, 1:16 AM

	F13255779: D20043.id47858.diff
	Sat, May 25, 7:57 AM

	F13245358: D20043.diff
	Thu, May 23, 5:58 AM

	F13219720: D20043.diff
	Sat, May 18, 8:17 PM

	F13185541: D20043.id47908.diff
	Sat, May 11, 2:59 AM

	Unknown Object (File)
	Tue, May 7, 9:13 AM

	Unknown Object (File)
	May 3 2024, 3:36 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13242: 2019 Week 5 Bonus Content

Commits

rP70b474e550b7: Allow MFA enrollment guidance to be customized

Summary

Depends on D20039. Ref T13242. If installs want users to install a specific application, reference particular help, etc., let them customize the MFA enrollment message so they can make it say "if you have issues, see this walkthrough on the corporate wiki" or whatever.

Test Plan

Screen Shot 2019-01-28 at 9.27.01 AM.png (995×1 px, 236 KB)

Screen Shot 2019-01-28 at 9.21.59 AM.png (970×1 px, 217 KB)

Screen Shot 2019-01-28 at 9.24.07 AM.png (855×1 px, 153 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 28 2019, 5:28 PM

Harbormaster completed remote builds in B21712: Diff 47858.Jan 28 2019, 5:30 PM

epriestley requested review of this revision.Jan 28 2019, 5:30 PM

amckinley accepted this revision.Jan 29 2019, 3:15 AM

This revision is now accepted and ready to land.Jan 29 2019, 3:15 AM

Closed by commit rP70b474e550b7: Allow MFA enrollment guidance to be customized (authored by epriestley). · Explain WhyJan 30 2019, 2:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

auth/

application/

PhabricatorAuthApplication.php

2 lines

controller/

mfa/

PhabricatorAuthFactorProviderMessageController.php

84 lines

PhabricatorAuthFactorProviderViewController.php

18 lines

storage/

PhabricatorAuthFactorProvider.php

8 lines

xaction/

PhabricatorAuthFactorProviderEnrollMessageTransaction.php

39 lines

settings/

panel/

PhabricatorMultiFactorSettingsPanel.php

7 lines

Diff 47908

src/__phutil_library_map__.php

Loading...

src/applications/auth/application/PhabricatorAuthApplication.php

Loading...

src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderMessageController.php

Loading...

src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php

Loading...

src/applications/auth/storage/PhabricatorAuthFactorProvider.php

Loading...

src/applications/auth/xaction/PhabricatorAuthFactorProviderEnrollMessageTransaction.php

Loading...

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

Loading...