Page MenuHomePhabricator
Differential D19790

Continue making application fixes to Phabricator for changes to %Q semantics
ClosedPublic
Actions

Authored by epriestley on Nov 7 2018, 12:59 PM.
Tags
None
Referenced Files
F13269878: D19790.diff
Wed, May 29, 8:02 AM
F13193927: D19790.id47304.diff
Sun, May 12, 7:25 PM
F13190370: D19790.id.diff
Sat, May 11, 10:15 AM
Unknown Object (File)
Wed, May 1, 12:31 AM
Unknown Object (File)
Apr 25 2024, 8:53 PM
Unknown Object (File)
Apr 25 2024, 3:40 PM
Unknown Object (File)
Apr 20 2024, 9:20 AM
Unknown Object (File)
Apr 19 2024, 8:05 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13217: Upgrading: Hardening of qsprintf()
Commits
rP2f10d4adebf9: Continue making application fixes to Phabricator for changes to %Q semantics
Summary

Depends on D19789. Ref T13217. Continue updating things to use the new %Q-flavored conversions instead of smushing a bunch of strings together.

Test Plan

Browsed around, far fewer errors. These changes are largely mechanical in nature.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 7 2018, 12:59 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2018, 1:01 PM
Harbormaster failed remote builds in B21106: Diff 47258!
epriestley requested review of this revision.Nov 13 2018, 4:54 PM
amckinley accepted this revision.Nov 15 2018, 3:19 AM
This revision is now accepted and ready to land.Nov 15 2018, 3:19 AM
Closed by commit rP2f10d4adebf9: Continue making application fixes to Phabricator for changes to %Q semantics (authored by epriestley). · Explain WhyNov 15 2018, 11:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
engine/
8 lines
query/
2 lines
calendar/
query/
1 line
differential/
query/
32 lines
maniphest/
editor/
47 lines
query/
16 lines
people/
storage/
4 lines
infrastructure/
cluster/
10 lines
edges/
editor/
10 lines
query/
6 lines
query/
policy/
45 lines
storage/
lisk/
22 lines

Diff 47304

View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

Loading...
View Options

src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Loading...
View Options

src/infrastructure/edges/editor/PhabricatorEdgeEditor.php

Loading...
View Options

src/infrastructure/edges/query/PhabricatorEdgeQuery.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAO.php

Loading...
Phabricator · Built by Phacility