Page MenuHomePhabricator

Fix `arc diff` when adding large new file with new git
ClosedPublic

Authored by avivey on Jul 8 2018, 11:39 PM.
Tags
None
Referenced Files
F13225260: D19513.diff
Sun, May 19, 2:16 PM
F13212001: D19513.diff
Fri, May 17, 6:18 AM
F13195635: D19513.diff
Sun, May 12, 10:32 PM
F13178364: D19513.diff
Wed, May 8, 8:22 PM
Unknown Object (File)
Thu, Apr 25, 2:43 AM
Unknown Object (File)
Apr 19 2024, 7:49 PM
Unknown Object (File)
Apr 17 2024, 3:01 PM
Unknown Object (File)
Mar 31 2024, 9:53 PM
Subscribers

Details

Summary

See https://discourse.phabricator-community.org/t/arc-not-supporting-git-2-17-1/.
When treating it a large file binary, we try to get the "old" and "new" content using git ls-tree and cat-file.
If the file is new or deleted, there is no old file, so we try to work with filename null.

Under git < 2.17.1, that gets treated as git ls-tree -- ., which falls in the next condition under "no such path".
In git 2.18, etc, this is an error.

Explicitly bail out if there is no filename.

Test Plan

Add a new, large (>4Mb) file, arc diff.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable