Page MenuHomePhabricator

Move Harbormaster log compression to the worker task queue
ClosedPublic

Authored by epriestley on Feb 23 2018, 2:20 AM.
Tags
None
Referenced Files
F13225300: D19131.id45852.diff
Sun, May 19, 2:30 PM
F13221799: D19131.diff
Sun, May 19, 3:03 AM
F13204509: D19131.diff
Wed, May 15, 12:39 AM
F13186814: D19131.diff
Sat, May 11, 4:04 AM
Unknown Object (File)
Tue, May 7, 7:40 AM
Unknown Object (File)
May 4 2024, 4:43 AM
Unknown Object (File)
May 3 2024, 5:17 AM
Unknown Object (File)
Apr 25 2024, 1:09 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19130. Ref T13088. Currently, when a build log is closed we compress it in the same process. Separate this out into a dedicated worker since the plan is to do a lot more work during finalization, none of which needs to happen inline during builds (or, particuarly, inline during a Conduit call for API writes in the future).

Test Plan

Ran bin/harbormaster write-log --trace, saw compression run inline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 2:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:52 AM
This revision was automatically updated to reflect the committed changes.