Page MenuHomePhabricator
Differential D18982

Add withNameGlob() to FileFinder
ClosedPublic
Actions

Authored by epriestley on Jan 31 2018, 10:38 PM.
Tags
None
Referenced Files
F13298770: D18982.diff
Fri, Jun 7, 7:14 AM
F13229054: D18982.id45517.diff
Mon, May 20, 2:04 PM
F13220073: D18982.diff
Sat, May 18, 11:07 PM
F13214102: D18982.id.diff
Fri, May 17, 8:35 AM
F13209005: D18982.diff
Thu, May 16, 9:01 PM
F13175756: D18982.diff
May 8 2024, 7:14 AM
Unknown Object (File)
Apr 19 2024, 7:14 PM
Unknown Object (File)
Apr 6 2024, 2:09 PM
View All 93 Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPHUfb082fb35626: (stable) Promote 2018 Week 5
rPHUcc343d0c8133: Add withNameGlob() to FileFinder
Summary

Depends on D18981. See PHI336. Addresses the use case test_*.py in a portable way.

Test Plan

Added unit tests; ran unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 31 2018, 10:38 PM
Harbormaster completed remote builds in B19306: Diff 45517.Jan 31 2018, 10:38 PM
epriestley requested review of this revision.Jan 31 2018, 10:38 PM
amckinley accepted this revision.Jan 31 2018, 10:53 PM
This revision is now accepted and ready to land.Jan 31 2018, 10:53 PM
Closed by commit rPHUcc343d0c8133: Add withNameGlob() to FileFinder (authored by epriestley). · Explain WhyJan 31 2018, 11:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
filesystem/
33 lines
__tests__/
20 lines

Diff 45521

View Options

src/filesystem/FileFinder.php

Loading...
View Options

src/filesystem/__tests__/FileFinderTestCase.php

Loading...
Phabricator · Built by Phacility