Page MenuHomePhabricator

Make "first broadcast" rules for Differential drafts more general
ClosedPublic

Authored by epriestley on Nov 28 2017, 6:44 PM.
Tags
None
Referenced Files
F13255221: D18801.diff
Sat, May 25, 4:31 AM
F13234406: D18801.diff
Tue, May 21, 3:22 AM
F13212185: D18801.diff
Fri, May 17, 6:27 AM
F13209754: D18801.id.diff
Fri, May 17, 1:56 AM
F13195757: D18801.diff
Sun, May 12, 10:36 PM
F13178453: D18801.diff
Wed, May 8, 8:26 PM
Unknown Object (File)
Mon, May 6, 8:28 AM
Unknown Object (File)
Apr 26 2024, 2:59 AM
Subscribers
None

Details

Summary

See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan
  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable