Page MenuHomePhabricator

Issue upgrade guidance to rebuild indexes for the Ferret engine
ClosedPublic

Authored by epriestley on Sep 12 2017, 3:28 PM.
Tags
None
Referenced Files
F13282163: D18594.diff
Sun, Jun 2, 11:46 AM
F13246654: D18594.diff
Thu, May 23, 12:31 PM
F13236364: D18594.diff
Tue, May 21, 9:21 AM
F13212011: D18594.diff
Fri, May 17, 6:18 AM
F13201712: D18594.id44655.diff
Tue, May 14, 2:59 PM
F13197041: D18594.diff
Sun, May 12, 11:46 PM
F13184678: D18594.diff
Fri, May 10, 9:57 PM
Unknown Object (File)
May 6 2024, 2:27 PM
Subscribers
None

Details

Summary

Ref T12819. This is shipping, so issue upgrade guidance to instruct installs to rebuild the index.

Also generate a new quickstart.sql since we haven't regenerated in a bit and there's been a large amount of table churn fairly recently.

Test Plan

Ran bin/storage upgrade, saw guidance notification in UI.

Diff Detail

Repository
rP Phabricator
Branch
ferret9
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningresources/sql/quickstart.sql:118TXT3Line Too Long
Warningresources/sql/quickstart.sql:119TXT3Line Too Long
Warningresources/sql/quickstart.sql:120TXT3Line Too Long
Warningresources/sql/quickstart.sql:745TXT3Line Too Long
Warningresources/sql/quickstart.sql:746TXT3Line Too Long
Warningresources/sql/quickstart.sql:747TXT3Line Too Long
Warningresources/sql/quickstart.sql:1885TXT3Line Too Long
Warningresources/sql/quickstart.sql:1886TXT3Line Too Long
Warningresources/sql/quickstart.sql:1887TXT3Line Too Long
Warningresources/sql/quickstart.sql:1957TXT3Line Too Long
Warningresources/sql/quickstart.sql:2239TXT3Line Too Long
Warningresources/sql/quickstart.sql:2273TXT3Line Too Long
Warningresources/sql/quickstart.sql:2274TXT3Line Too Long
Warningresources/sql/quickstart.sql:2275TXT3Line Too Long
Warningresources/sql/quickstart.sql:2474TXT3Line Too Long
Warningresources/sql/quickstart.sql:2475TXT3Line Too Long
Warningresources/sql/quickstart.sql:2476TXT3Line Too Long
Warningresources/sql/quickstart.sql:2552TXT3Line Too Long
Warningresources/sql/quickstart.sql:2553TXT3Line Too Long
Warningresources/sql/quickstart.sql:2554TXT3Line Too Long
Warningresources/sql/quickstart.sql:2684TXT3Line Too Long
Warningresources/sql/quickstart.sql:2685TXT3Line Too Long
Warningresources/sql/quickstart.sql:2686TXT3Line Too Long
Warningresources/sql/quickstart.sql:2906TXT3Line Too Long
Warningresources/sql/quickstart.sql:2907TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 18427
Build 24813: Run Core Tests
Build 24812: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 12 2017, 5:59 PM
This revision was automatically updated to reflect the committed changes.
resources/sql/quickstart.sql
3480

Oh, these are actually wrong for quickstart (storage upgrade adjusts the table engine later if possible). These tables will also get killed off soon, hopefully.